Move tokenize_line method from TestExpectationParser to TestExpectationLine.

Move tokenize_line method from TestExpectationParser to TestExpectationLine.

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to re-use tokenize_line in update_w3c_test_expectations.py, in order to make it easier to fix http://crbug.com/647395.

BUG=647395
Committed: https://crrev.com/5ad02862242995ad53cf3e473aed5aa7b919153e
Cr-Commit-Position: refs/heads/master@{#419013}

[qyearsley, 2016-09-15 20:44:32]

Description was changed from

==========
Move tokenize_line method from TestExpectationParser to TestExpectationLine.

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by
FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

BUG=
==========

to

==========
Move tokenize_line method from TestExpectationParser to TestExpectationLine.

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by
FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to
re-use tokenize_line in update_w3c_test_expectations.py, in order to make it
easier to fix http://crbug.com/647395.

BUG=647395
==========

[qyearsley, 2016-09-15 20:44:32]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-09-15 20:55:41]

lgtm

[qyearsley, 2016-09-15 21:02:31]

https://codereview.chromium.org/2341173002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
(left):

https://codereview.chromium.org/2341173002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:393:
return [part.strip() for part in space_separated_string.strip().split(' ')]
Note: This CL removes this method which appears unused.

https://codereview.chromium.org/2341173002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:415:
self.is_skipped_outside_expectations_file = False
Note: This CL renames this variable to is_extra_skipped_test to make it shorter.
That's not really a super clear name, but the original name isn't super clear
either.

https://codereview.chromium.org/2341173002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
(right):

https://codereview.chromium.org/2341173002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:543:
new_specifiers.append(cls._inverted_configuration_tokens.get(specifier,
specifier))
Note: This CL changes this to a classmethod to indicate that it accesses the
protected class attribute _inverted_configuration_tokens.

[qyearsley, 2016-09-15 21:02:35]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:03:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:15:22]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-09-15 22:16:02]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:16:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:22:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 22:24:33]

Description was changed from

==========
Move tokenize_line method from TestExpectationParser to TestExpectationLine.

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by
FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to
re-use tokenize_line in update_w3c_test_expectations.py, in order to make it
easier to fix http://crbug.com/647395.

BUG=647395
==========

to

==========
Move tokenize_line method from TestExpectationParser to TestExpectationLine.

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by
FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to
re-use tokenize_line in update_w3c_test_expectations.py, in order to make it
easier to fix http://crbug.com/647395.

BUG=647395

Committed: https://crrev.com/5ad02862242995ad53cf3e473aed5aa7b919153e
Cr-Commit-Position: refs/heads/master@{#419013}
==========

[commit-bot: I haz the power, 2016-09-15 22:24:35]

Patchset 1 (id:??) landed as
https://crrev.com/5ad02862242995ad53cf3e473aed5aa7b919153e
Cr-Commit-Position: refs/heads/master@{#419013}