third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py - Issue 2341173002: Move tokenize_line method from TestExpectationParser to TestExpectationLine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

Issue 2341173002: Move tokenize_line method from TestExpectationParser to TestExpectationLine. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

index 5dbff14fb2249e381c4ee9643d372fc81c7d7916..2bc9cd994435fae57b4a4f48fabd7d63435b65e1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

@@ -463,7 +463,7 @@ class ExpectationSyntaxTests(Base):

expectations = expectations or []

warnings = warnings or []

line_number = '1'

- expectation_line = TestExpectationParser._tokenize_line(filename, line, line_number)

+ expectation_line = TestExpectationLine.tokenize_line(filename, line, line_number)

self.assertEqual(expectation_line.warnings, warnings)

self.assertEqual(expectation_line.name, name)

self.assertEqual(expectation_line.filename, filename)

@@ -904,7 +904,7 @@ class TestExpectationSerializationTests(unittest.TestCase):

unittest.TestCase.__init__(self, testFunc)

def _tokenize(self, line):

- return TestExpectationParser._tokenize_line('path', line, 0)

+ return TestExpectationLine.tokenize_line('path', line, 0)

def assert_round_trip(self, in_string, expected_string=None):

expectation = self._tokenize(in_string)