Canonicalize URLs prior to comparing in ManifestUpgradeDetector

chrome/test/data/banners/manifest_one_icon.json

Index: chrome/test/data/banners/manifest_one_icon.json
diff --git a/chrome/test/data/webapps/manifest.json b/chrome/test/data/banners/manifest_one_icon.json
similarity index 75%
copy from chrome/test/data/webapps/manifest.json
copy to chrome/test/data/banners/manifest_one_icon.json
index c26ce20d6ca80885eb1d419de1b5121c0ae1dd27..ad5e4994fde789e9174097b4fc02385313d21783 100644
--- a/chrome/test/data/webapps/manifest.json
+++ b/chrome/test/data/banners/manifest_one_icon.json
@@ -1,6 +1,5 @@
 {
   "name": "Manifest test app",

[dominickn, 2016/09/20 00:25:02]

Instead of creating new test files, can you use
chrome/test/data/webapps/manifest_test_page.html and
chrome/test/data/webapps/manifest.json? They seem to be essentially identical
for your purposes here.

At some point I am going to go and consolidate all of these test files for
webapps and banners into one directory.

[pkotwicz, 2016/09/20 02:34:29]

Thank you for the suggestion. Unfortunately,
chrome/test/data/webapps/manifest_test_page.html does not have a service worker
and the test page needs a service worker for my new tests.

[dominickn, 2016/09/20 02:41:25]

Acknowledged.

-  "short_name": "App",
   "icons": [
     {
       "src": "image-512px.png",
@@ -8,7 +7,7 @@
       "type": "image/png"
     }
   ],
-  "start_url": "manifest_test_page.html",
+  "start_url": "manifest_one_icon_test_page.html",
   "display": "standalone",
   "orientation": "landscape"
 }