chrome/test/data/banners/manifest_one_icon.json - Issue 2341163002: Canonicalize URLs prior to comparing in ManifestUpgradeDetector

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest_one_icon.json

Issue 2341163002: Canonicalize URLs prior to comparing in ManifestUpgradeDetector (Closed)

Patch Set: Merge branch 'master' into url_canonicalize Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "name": "Manifest test app",	2 "name": "Manifest test app",
	dominickn 2016/09/20 00:25:02 Instead of creating new test files, can you use ch Instead of creating new test files, can you use chrome/test/data/webapps/manifest_test_page.html and chrome/test/data/webapps/manifest.json? They seem to be essentially identical for your purposes here. At some point I am going to go and consolidate all of these test files for webapps and banners into one directory. pkotwicz 2016/09/20 02:34:29 Thank you for the suggestion. Unfortunately, chrom Thank you for the suggestion. Unfortunately, chrome/test/data/webapps/manifest_test_page.html does not have a service worker and the test page needs a service worker for my new tests. dominickn 2016/09/20 02:41:25 Acknowledged. Show quoted text On 2016/09/20 02:34:29, pkotwicz wrote: > Thank you for the suggestion. Unfortunately, > chrome/test/data/webapps/manifest_test_page.html does not have a service worker > and the test page needs a service worker for my new tests. Acknowledged.
3 "short_name": "App",

4 "icons": [	3 "icons": [

5 {	4 {

6 "src": "image-512px.png",	5 "src": "image-512px.png",

7 "sizes": "512x512",	6 "sizes": "512x512",

8 "type": "image/png"	7 "type": "image/png"

9 }	8 }

10 ],	9 ],

11 "start_url": "manifest_test_page.html",	10 "start_url": "manifest_one_icon_test_page.html",

12 "display": "standalone",	11 "display": "standalone",

13 "orientation": "landscape"	12 "orientation": "landscape"

14 }	13 }

OLD	NEW