Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2341083002: Revert of ozone: Sort U and V plane when creating an image. (Closed)

Created:
4 years, 3 months ago by Daniele Castagna
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of ozone: Sort U and V plane when creating an image. (patchset #1 id:1 of https://codereview.chromium.org/2334143003/ ) Reason for revert: This manual merge is broken. It is missing the attribute EGL_DMA_BUF_PLANE?_FD_EXT. Original issue's description: > ozone: Sort U and V plane when creating an image. > > Manual merge of crrev.com/2295943002 to M53. > > By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar > format, the plane 1 and 2 should always be U and V. > > Intel mesa currently doesn't follow the spec and does the swap on its > own. > > BUG=646136, 646137 , b/31164247 > TEST=External video on samus. > NOTRY=true > NOPRESUBMIT=true > > Review-Url: https://codereview.chromium.org/2295943002 > Cr-Commit-Position: refs/heads/master@{#418082} TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646136, 646137 , b/31164247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -52 lines) Patch
M ui/gl/gl_image_ozone_native_pixmap.cc View 2 chunks +10 lines, -52 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Daniele Castagna
Created Revert of ozone: Sort U and V plane when creating an image.
4 years, 3 months ago (2016-09-15 15:57:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341083002/1
4 years, 3 months ago (2016-09-15 15:57:57 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-15 15:58:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341083002/1
4 years, 3 months ago (2016-09-15 16:00:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 16:03:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698