ozone: Sort U and V plane when creating an image.

ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137
, b/31164247
TEST=External video on samus.

Committed: https://crrev.com/38a2205e8f3f551e6059fe657c2c8da246a8ba45
Cr-Commit-Position: refs/heads/master@{#418082}

[Daniele Castagna, 2016-08-30 18:16:52]

Description was changed from

==========
ozone: Sort U and V plane creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=b/31164247
TEST=Youtube video on samus.
==========

to

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=b/31164247
TEST=Youtube video on samus.
==========

[Daniele Castagna, 2016-08-30 18:17:32]

dcastagna@chromium.org changed reviewers:
+ hoegsberg@chromium.org, reveman@chromium.org, tfiga@chromium.org

[reveman, 2016-08-30 18:26:10]

lgtm

[hoegsberg1, 2016-08-30 18:45:45]

hoegsberg@google.com changed reviewers:
+ hoegsberg@google.com

[hoegsberg1, 2016-08-30 18:45:46]

Yes, LGTM, but we might as well fix the intel driver first and avoid the #ifdef
in the first place.

[hoegsberg1, 2016-08-31 22:43:29]

On 2016/08/30 18:45:46, hoegsberg1 wrote:
> Yes, LGTM, but we might as well fix the intel driver first and avoid the
#ifdef
> in the first place.

Let's hold this and figure out who is and isn't following the spec first.

[Daniele Castagna, 2016-09-12 19:21:05]

On 2016/08/31 at 22:43:29, hoegsberg wrote:
> On 2016/08/30 18:45:46, hoegsberg1 wrote:
> > Yes, LGTM, but we might as well fix the intel driver first and avoid the
#ifdef
> > in the first place.
> 
> Let's hold this and figure out who is and isn't following the spec first.

Landing this as per discussion via IM.

[Daniele Castagna, 2016-09-12 19:21:13]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:21:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:28:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniele Castagna, 2016-09-12 19:29:41]

dcastagna@chromium.org changed reviewers:
+ spang@chromium.org

[Daniele Castagna, 2016-09-12 19:29:41]

+spang for ownership.

[spang, 2016-09-12 21:21:16]

lgtm

https://codereview.chromium.org/2295943002/diff/1/ui/ozone/gl/gl_image_ozone_...
File ui/ozone/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2295943002/diff/1/ui/ozone/gl/gl_image_ozone_...
ui/ozone/gl/gl_image_ozone_native_pixmap.cc:187: // Once crbug.com/31164247 is
addressed this ifdef (but not its content) can be
Link is for wrong bug tracker.

[Daniele Castagna, 2016-09-12 21:54:17]

Description was changed from

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=b/31164247
TEST=Youtube video on samus.
==========

to

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137, b/31164247
TEST=Youtube video on samus.
==========

[Daniele Castagna, 2016-09-12 21:56:08]

https://codereview.chromium.org/2295943002/diff/1/ui/ozone/gl/gl_image_ozone_...
File ui/ozone/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2295943002/diff/1/ui/ozone/gl/gl_image_ozone_...
ui/ozone/gl/gl_image_ozone_native_pixmap.cc:187: // Once crbug.com/31164247 is
addressed this ifdef (but not its content) can be
On 2016/09/12 at 21:21:16, spang wrote:
> Link is for wrong bug tracker.

Filed a bug on crbug.com/646137 and linked to that one.

[Daniele Castagna, 2016-09-12 21:56:19]

Description was changed from

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137, b/31164247
TEST=Youtube video on samus.
==========

to

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137, b/31164247
TEST=External video on samus.
==========

[Daniele Castagna, 2016-09-12 21:56:34]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-09-12 21:56:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
hoegsberg@google.com, reveman@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2295943002/#ps20001
(title: "Link to correct bug.")

[commit-bot: I haz the power, 2016-09-12 21:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:40:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 22:43:12]

Description was changed from

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137, b/31164247
TEST=External video on samus.
==========

to

==========
ozone: Sort U and V plane when creating an image.

By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar
format, the plane 1 and 2 should always be U and V.

Intel mesa currently doesn't follow the spec and does the swap on its
own.

BUG=646136, 646137, b/31164247
TEST=External video on samus.

Committed: https://crrev.com/38a2205e8f3f551e6059fe657c2c8da246a8ba45
Cr-Commit-Position: refs/heads/master@{#418082}
==========

[commit-bot: I haz the power, 2016-09-12 22:43:14]

Patchset 2 (id:??) landed as
https://crrev.com/38a2205e8f3f551e6059fe657c2c8da246a8ba45
Cr-Commit-Position: refs/heads/master@{#418082}