Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: third_party/WebKit/Source/core/dom/Range.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)
Patch Set: minor revision Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Range.cpp
diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp
index 97ba6fb2c789592035087ddfb66deb7e7e429d3e..67305ca845e14dbc2158b87095a59debea84cda7 100644
--- a/third_party/WebKit/Source/core/dom/Range.cpp
+++ b/third_party/WebKit/Source/core/dom/Range.cpp
@@ -1462,8 +1462,8 @@ void Range::didSplitTextNode(Text& oldNode)
void Range::expand(const String& unit, ExceptionState& exceptionState)
yosin_UTC9 2016/09/16 02:01:21 We should get rid of Range#expand() since it is Bl
{
- VisiblePosition start = createVisiblePosition(startPosition());
- VisiblePosition end = createVisiblePosition(endPosition());
+ VisiblePosition start = createVisiblePositionDeprecated(startPosition());
+ VisiblePosition end = createVisiblePositionDeprecated(endPosition());
if (unit == "word") {
start = startOfWord(start);
end = endOfWord(end);

Powered by Google App Engine
This is Rietveld 408576698