Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2341033002: Revert of Implement QuicHttpStream::GetLoadTimingInfo (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement QuicHttpStream::GetLoadTimingInfo (patchset #7 id:200001 of https://codereview.chromium.org/2324183002/ ) Reason for revert: URLRequestQuicTest.TestTwoRequests is flaky, see https://crbug.com/647071. Original issue's description: > Implement QuicHttpStream::GetLoadTimingInfo > > This CL implements QuicHttpStream::GetLoadTimingInfo. > > |dns_start| and |dns_end| are obtained in > QuicStreamFactory::Job::DoResolveHost and > DoResolveHostComplete. These two values are passed to > QuicChromiumClientSession's constructor. > > |connect_start| and |connect_end| are obtained in > QuicChromiumClientSession::CrytoConnect() and when > handshake is confirmed. > > |ssl_start| and |ssl_end| are the same as |connect_start| > and |connect_end| because QUIC always does encryption. > > If a session is reused, the connect_timing fields should > all be null. This CL also sets > |socket_reused| field of LoadTimingInfo accordingly. > > BUG=637051 > > Committed: https://crrev.com/5608fc1bd4f0a80b6d1996f3f4059f2efa0a0777 > Committed: https://crrev.com/83ac2f22700c563fef8a670ad4c5c57d34032e03 > Cr-Original-Commit-Position: refs/heads/master@{#417969} > Cr-Commit-Position: refs/heads/master@{#418567} TBR=rch@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=637051 Committed: https://crrev.com/f94df884d60b6b3f345c1575292b557eabd5ee0a Cr-Commit-Position: refs/heads/master@{#418815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -401 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 4 chunks +2 lines, -5 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 8 chunks +8 lines, -27 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_http_stream.h View 3 chunks +0 lines, -8 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 4 chunks +1 line, -14 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 7 chunks +7 lines, -123 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 5 chunks +5 lines, -9 lines 0 comments Download
D net/url_request/url_request_quic_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
grt (UTC plus 2)
Created Revert of Implement QuicHttpStream::GetLoadTimingInfo
4 years, 3 months ago (2016-09-15 09:43:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341033002/1
4 years, 3 months ago (2016-09-15 09:43:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 09:44:23 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 09:46:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f94df884d60b6b3f345c1575292b557eabd5ee0a
Cr-Commit-Position: refs/heads/master@{#418815}

Powered by Google App Engine
This is Rietveld 408576698