Revert of Implement QuicHttpStream::GetLoadTimingInfo

net/quic/chromium/quic_chromium_client_session.cc

Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 7f36db24a72a20b76f831c823da929af7ba6058d..1b008407205790ab9b1bb0bf09cdf7ca585c9771 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -219,7 +219,6 @@
     const QuicConfig& config,
     QuicCryptoClientConfig* crypto_config,
     const char* const connection_description,
-    base::TimeTicks dns_resolution_start_time,
     base::TimeTicks dns_resolution_end_time,
     QuicClientPushPromiseIndex* push_promise_index,
     base::TaskRunner* task_runner,
@@ -235,6 +234,7 @@
       num_total_streams_(0),
       task_runner_(task_runner),
       net_log_(BoundNetLog::Make(net_log, NetLogSourceType::QUIC_SESSION)),
+      dns_resolution_end_time_(dns_resolution_end_time),
       logger_(new QuicConnectionLogger(this,
                                        connection_description,
                                        std::move(socket_performance_watcher),
@@ -266,8 +266,6 @@
     connection->SetMaxPacketLength(connection->max_packet_length() -
                                    kAdditionalOverheadForIPv6);
   }
-  connect_timing_.dns_start = dns_resolution_start_time;
-  connect_timing_.dns_end = dns_resolution_end_time;
 }
 
 QuicChromiumClientSession::~QuicChromiumClientSession() {
@@ -622,15 +620,13 @@
     bool require_confirmation,
     const CompletionCallback& callback) {
   require_confirmation_ = require_confirmation;
-  connect_timing_.connect_start = base::TimeTicks::Now();
+  handshake_start_ = base::TimeTicks::Now();
   RecordHandshakeState(STATE_STARTED);
   DCHECK(flow_controller());
   crypto_stream_->CryptoConnect();
 
-  if (IsCryptoHandshakeConfirmed()) {
-    connect_timing_.connect_end = base::TimeTicks::Now();
+  if (IsCryptoHandshakeConfirmed())
     return OK;
-  }
 
   // Unless we require handshake confirmation, activate the session if
   // we have established initial encryption.
@@ -643,10 +639,8 @@
 
 int QuicChromiumClientSession::ResumeCryptoConnect(
     const CompletionCallback& callback) {
-  if (IsCryptoHandshakeConfirmed()) {
-    connect_timing_.connect_end = base::TimeTicks::Now();
+  if (IsCryptoHandshakeConfirmed())
     return OK;
-  }
 
   if (!connection()->connected())
     return ERR_QUIC_HANDSHAKE_FAILED;
@@ -796,14 +790,8 @@
     base::ResetAndReturn(&callback_).Run(OK);
   }
   if (event == HANDSHAKE_CONFIRMED) {
-    // Update |connect_end| only when handshake is confirmed. This should also
-    // take care of any failed 0-RTT request.
-    connect_timing_.connect_end = base::TimeTicks::Now();
-    DCHECK(connect_timing_.connect_start < connect_timing_.connect_end);
-    UMA_HISTOGRAM_TIMES(
-        "Net.QuicSession.HandshakeConfirmedTime",
-        connect_timing_.connect_end - connect_timing_.connect_start);
-
+    UMA_HISTOGRAM_TIMES("Net.QuicSession.HandshakeConfirmedTime",
+                        base::TimeTicks::Now() - handshake_start_);
     if (server_info_) {
       // TODO(rtenneti): Should we delete this histogram?
       // Track how long it has taken to finish handshake once we start waiting
@@ -820,10 +808,10 @@
     }
     // Track how long it has taken to finish handshake after we have finished
     // DNS host resolution.
-    if (!connect_timing_.dns_end.is_null()) {
+    if (!dns_resolution_end_time_.is_null()) {
       UMA_HISTOGRAM_TIMES(
           "Net.QuicSession.HostResolution.HandshakeConfirmedTime",
-          base::TimeTicks::Now() - connect_timing_.dns_end);
+          base::TimeTicks::Now() - dns_resolution_end_time_);
     }
 
     ObserverSet::iterator it = observers_.begin();
@@ -1392,11 +1380,4 @@
   QuicClientSessionBase::DeletePromised(promised);
 }
 
-const LoadTimingInfo::ConnectTiming&
-QuicChromiumClientSession::GetConnectTiming() {
-  connect_timing_.ssl_start = connect_timing_.connect_start;
-  connect_timing_.ssl_end = connect_timing_.connect_end;
-  return connect_timing_;
-}
-
 }  // namespace net