Issue 234103003: Revert 263093 "roll skia DEPS to 14128"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234103003: Revert 263093 "roll skia DEPS to 14128" (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
benchen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 263093 "roll skia DEPS to 14128" Broke iOS Simulator (dbg): http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/15778 Ld /b/build/slave/iOS_Simulator__dbg_/build/src/xcodebuild/Debug-iphonesimulator/components_unittests.app/components_unittests normal i386 [...] Undefined symbols for architecture i386: "SkSSE2ProcCoeffXfermode::SkSSE2ProcCoeffXfermode(SkReadBuffer&)", referenced from: SkSSE2ProcCoeffXfermode::CreateProc(SkReadBuffer&) in libskia_library.a(SkXfermode.o) ld: symbol(s) not found for architecture i386 > roll skia DEPS to 14128 > > Chromium base revision: 262955 / > Old Skia revision: 14102 > New Skia revision: 14128 > Control CL: https://codereview.chromium.org/233193002/ > > Bypassing commit queue trybots: > NOTRY=true > > Review URL: https://codereview.chromium.org/232783004 TBR=bensong@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263112

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -14 lines)			Patch
	M	trunk/src/DEPS	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	trunk/src/skia/skia_library_opts.gyp	View		2 chunks	+7 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

viettrungluu

6 years, 8 months ago (2014-04-10 22:56:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r263112 (tree was closed).