Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 232783004: roll skia DEPS to 14128 (Closed)

Created:
6 years, 8 months ago by benchen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, skia-team_google.com
Visibility:
Public.

Description

roll skia DEPS to 14128 Chromium base revision: 262955 / Old Skia revision: 14102 New Skia revision: 14128 Control CL: https://codereview.chromium.org/233193002/ Bypassing commit queue trybots: NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benchen
This looks 'good'. I'm not very sure about the extra win failures, but for the ...
6 years, 8 months ago (2014-04-10 21:00:55 UTC) #1
mtklein
GYP LGTM
6 years, 8 months ago (2014-04-10 21:02:51 UTC) #2
reed1
lgtm
6 years, 8 months ago (2014-04-10 21:19:32 UTC) #3
benchen
The CQ bit was checked by bensong@google.com
6 years, 8 months ago (2014-04-10 21:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bensong@google.com/232783004/1
6 years, 8 months ago (2014-04-10 21:23:27 UTC) #5
commit-bot: I haz the power
Change committed as 263093
6 years, 8 months ago (2014-04-10 21:44:49 UTC) #6
benchen
6 years, 8 months ago (2014-04-10 22:37:09 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/229893004/ by bensong@google.com.

The reason for reverting is: breaking Chrome bots
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu....

Powered by Google App Engine
This is Rietveld 408576698