Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2340903002: Revert of [modules] Make duplicate export error deterministic. (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
Reviewers:
neis, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [modules] Make duplicate export error deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2331003002/ ) Reason for revert: Seems to break one of our arm64 bots: https://chromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/2303 Original issue's description: > [modules] Make duplicate export error deterministic. > > In case of duplicate exports, always report the error for the very last > one. > > R=adamk@chromium.org > BUG=v8:5358, v8:1569 > > Committed: https://crrev.com/da1f911c4269048d24a3442791b18523455f3b24 > Cr-Commit-Position: refs/heads/master@{#39424} TBR=adamk@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5358, v8:1569 Committed: https://crrev.com/7b9d6bbcf3d14839638054f8cdf177f43b5aa739 Cr-Commit-Position: refs/heads/master@{#39430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M src/ast/modules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/modules.cc View 1 chunk +3 lines, -16 lines 0 comments Download
M test/message/export-duplicate.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/message/export-duplicate.out View 1 chunk +3 lines, -3 lines 0 comments Download
M test/message/export-duplicate-as.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-as.out View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-default.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/message/export-duplicate-default.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/message.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [modules] Make duplicate export error deterministic.
4 years, 3 months ago (2016-09-14 21:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340903002/1
4 years, 3 months ago (2016-09-14 21:51:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:51:48 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:52:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b9d6bbcf3d14839638054f8cdf177f43b5aa739
Cr-Commit-Position: refs/heads/master@{#39430}

Powered by Google App Engine
This is Rietveld 408576698