Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2340893003: Support interpolation of animatable shorthand properties containing var() (Closed)

Created:
4 years, 3 months ago by alancutter (OOO until 2018)
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support interpolation of animatable shorthand properties containing var() This change adds support for handling pending substitution values to CSS animations to allow for smooth interpolation between shorthand values with var() references in them. BUG=647123 Committed: https://crrev.com/ee86696437fd6bc8f16d8ab872263cef2c02131b Cr-Commit-Position: refs/heads/master@{#419096}

Patch Set 1 #

Patch Set 2 : Update DCHECK #

Messages

Total messages: 12 (7 generated)
alancutter (OOO until 2018)
4 years, 3 months ago (2016-09-15 04:35:12 UTC) #2
Timothy Loh
On 2016/09/15 04:35:12, alancutter wrote: lgtm
4 years, 3 months ago (2016-09-16 03:57:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340893003/20001
4 years, 3 months ago (2016-09-16 04:02:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 04:07:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 04:10:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee86696437fd6bc8f16d8ab872263cef2c02131b
Cr-Commit-Position: refs/heads/master@{#419096}

Powered by Google App Engine
This is Rietveld 408576698