Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 2340893003: Support interpolation of animatable shorthand properties containing var() (Closed)
Patch Set: Update DCHECK Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp
diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
index 5d3f3accb1c857bf07a356e5bbd2503a9571b2d7..0d1fc97dd6a4be09bc81ef9e0b6312c2d21494ee 100644
--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
@@ -55,8 +55,7 @@ PropertyHandleSet StringKeyframe::properties() const
PropertyHandleSet properties;
for (unsigned i = 0; i < m_cssPropertyMap->propertyCount(); ++i) {
StylePropertySet::PropertyReference propertyReference = m_cssPropertyMap->propertyAt(i);
- DCHECK(
- !isShorthandProperty(propertyReference.id()) || propertyReference.value().isVariableReferenceValue())
+ DCHECK(!isShorthandProperty(propertyReference.id()))
<< "Web Animations: Encountered unexpanded shorthand CSS property (" << propertyReference.id() << ").";
properties.add(PropertyHandle(propertyReference.id(), false));
}

Powered by Google App Engine
This is Rietveld 408576698