Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js based tests

Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js based tests

BUG=636710
Committed: https://crrev.com/59d11b3db24afc3593b1a925beb75b7a6b88dffc
Cr-Commit-Position: refs/heads/master@{#418809}

[Shanmuga Pandi, 2016-09-14 10:57:08]

shanmuga.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Shanmuga Pandi, 2016-09-14 10:57:09]

PTAL!!

[Srirama, 2016-09-14 12:50:21]

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:38:
assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value,
text1.x.baseVal.getItem(5).value);
try using assert_object_equals instead of checking value.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:49:
assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(0)).value,
text1.x.baseVal.getItem(6).value);
ditto.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:61:
assert_equals(text1.x.baseVal.appendItem(newLength1).value,
text1.x.baseVal.getItem(7).value);
same here as well and in all other places.

[Shanmuga Pandi, 2016-09-14 13:28:17]

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:38:
assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value,
text1.x.baseVal.getItem(5).value);
On 2016/09/14 12:50:21, Srirama wrote:
> try using assert_object_equals instead of checking value.

assert_object_equals is not working for SVG TearOff type object

[Srirama, 2016-09-14 14:05:33]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com

[Srirama, 2016-09-14 14:05:34]

+fs

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:38:
assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value,
text1.x.baseVal.getItem(5).value);
On 2016/09/14 13:28:17, Shanmuga Pandi wrote:
> On 2016/09/14 12:50:21, Srirama wrote:
> > try using assert_object_equals instead of checking value.
> 
> assert_object_equals is not working for SVG TearOff type object

Acknowledged.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml
(left):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml:134:
debug("The test passes if you only see 'PASS' messages, and all three text
elements on top look the same");
This is expecting the 3 text elements to be rendered same. So probably we need a
reference test here or we should at least keep the .png files for reference for
now? Other than that the changes are ok for me. Let see what fs says.

[fs, 2016-09-14 15:14:36]

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:2:
<title>SVGLengthList Interface - appendItem()</title>
Could make this "SVGLengthList.appendItem()" or "SVGLengthList, appendItem()" or
so - no need to have the interface here I think.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:6: <text
id="text1" x="500 50 100 900 1000" y="50">ABC</text>
Does this work out with not needing an expectation file?

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:22:
assert_equals(text1.x.baseVal.numberOfItems, 5);
I think we an cut down on the boilerplate a bit here:

var xList1 = text1.x.baseVal;

and then use that. (Hopefully that works...)

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml
(left):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml:134:
debug("The test passes if you only see 'PASS' messages, and all three text
elements on top look the same");
On 2016/09/14 at 14:05:33, Srirama wrote:
> This is expecting the 3 text elements to be rendered same. So probably we need
a reference test here or we should at least keep the .png files for reference
for now? Other than that the changes are ok for me. Let see what fs says.

Since this test would've been completed before 'load' I suspect it's not very
interesting to keep the visual part of it. I think we have coverage for this
type of mutation elsewhere, but feel free to verify.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItemFromClearedList.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItemFromClearedList.html:2:
<title>SVGLengthList Interface - appendItem() from cleared list</title>
Ditto ("SVGLengthList, appendItem() from ...")

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html (right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html:2:
<title>SVGLengthList Interface - basics</title>
Ditto.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html:10: var text1 =
document.querySelector("text");
Suggest aliasing the list(s) once here too.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html (right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html:2:
<title>SVGLengthList Interface - getItem()</title>
Ditto.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html:11: var text1
= document.querySelector("text");
Make this reference the list instead.

[Shanmuga Pandi, 2016-09-15 06:16:42]

The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 06:16:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shanmuga Pandi, 2016-09-15 06:18:19]

PTAL!

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:2:
<title>SVGLengthList Interface - appendItem()</title>
On 2016/09/14 15:14:35, fs wrote:
> Could make this "SVGLengthList.appendItem()" or "SVGLengthList, appendItem()"
or
> so - no need to have the interface here I think.

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:6: <text
id="text1" x="500 50 100 900 1000" y="50">ABC</text>
On 2016/09/14 15:14:35, fs wrote:
> Does this work out with not needing an expectation file?

It works. Will trigger CQ.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:22:
assert_equals(text1.x.baseVal.numberOfItems, 5);
On 2016/09/14 15:14:35, fs wrote:
> I think we an cut down on the boilerplate a bit here:
> 
> var xList1 = text1.x.baseVal;
> 
> and then use that. (Hopefully that works...)

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml
(left):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml:134:
debug("The test passes if you only see 'PASS' messages, and all three text
elements on top look the same");
On 2016/09/14 15:14:35, fs wrote:
> On 2016/09/14 at 14:05:33, Srirama wrote:
> > This is expecting the 3 text elements to be rendered same. So probably we
need
> a reference test here or we should at least keep the .png files for reference
> for now? Other than that the changes are ok for me. Let see what fs says.
> 
> Since this test would've been completed before 'load' I suspect it's not very
> interesting to keep the visual part of it. I think we have coverage for this
> type of mutation elsewhere, but feel free to verify.

Acknowledged.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItemFromClearedList.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItemFromClearedList.html:2:
<title>SVGLengthList Interface - appendItem() from cleared list</title>
On 2016/09/14 15:14:35, fs wrote:
> Ditto ("SVGLengthList, appendItem() from ...")

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html (right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html:2:
<title>SVGLengthList Interface - basics</title>
On 2016/09/14 15:14:35, fs wrote:
> Ditto.

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-basics.html:10: var text1 =
document.querySelector("text");
On 2016/09/14 15:14:35, fs wrote:
> Suggest aliasing the list(s) once here too.

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html (right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html:2:
<title>SVGLengthList Interface - getItem()</title>
On 2016/09/14 15:14:35, fs wrote:
> Ditto.

Done.

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-getItem.html:11: var text1
= document.querySelector("text");
On 2016/09/14 15:14:35, fs wrote:
> Make this reference the list instead.

Done.

[commit-bot: I haz the power, 2016-09-15 07:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 07:19:47]

Dry run: This issue passed the CQ dry run.

[Shanmuga Pandi, 2016-09-15 07:27:16]

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html
(right):

https://codereview.chromium.org/2340733002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html:6: <text
id="text1" x="500 50 100 900 1000" y="50">ABC</text>
On 2016/09/15 06:18:18, Shanmuga Pandi wrote:
> On 2016/09/14 15:14:35, fs wrote:
> > Does this work out with not needing an expectation file?
> 
> It works. Will trigger CQ.

This passed the CQ dry run.

[fs, 2016-09-15 08:34:03]

lgtm

[Shanmuga Pandi, 2016-09-15 08:35:01]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-09-15 08:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 08:40:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 08:42:30]

Description was changed from

==========
Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js
based tests

BUG=636710
==========

to

==========
Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js
based tests

BUG=636710

Committed: https://crrev.com/59d11b3db24afc3593b1a925beb75b7a6b88dffc
Cr-Commit-Position: refs/heads/master@{#418809}
==========

[commit-bot: I haz the power, 2016-09-15 08:42:31]

Patchset 3 (id:??) landed as
https://crrev.com/59d11b3db24afc3593b1a925beb75b7a6b88dffc
Cr-Commit-Position: refs/heads/master@{#418809}