Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.html

Issue 2340733002: Convert LayoutTests/svg/dom/SVGLengthList*.html js-tests.js to testharness.js based tests (Closed)
Patch Set: nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/svg/dom/SVGLengthList-getItem-expected.png ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml » ('j') | third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE HTML>
2 <title>SVGLengthList Interface - appendItem()</title>
fs 2016/09/14 15:14:35 Could make this "SVGLengthList.appendItem()" or "S
Shanmuga Pandi 2016/09/15 06:18:18 Done.
3 <script src="../../resources/testharness.js"></script>
4 <script src="../../resources/testharnessreport.js"></script>
5 <svg width="200" height="200">
6 <text id="text1" x="500 50 100 900 1000" y="50">ABC</text>
fs 2016/09/14 15:14:35 Does this work out with not needing an expectation
Shanmuga Pandi 2016/09/15 06:18:18 It works. Will trigger CQ.
Shanmuga Pandi 2016/09/15 07:27:15 This passed the CQ dry run.
7 <text id="text2" x="50 100 1000" y="100">ABC</text>
8 </svg>
9 <script>
10 test(function() {
11 // This is a test of the SVGLengthList::appendItem() API.
12 var svg = document.querySelector("svg");
13 var text1 = document.getElementById("text1");
14 var text2 = document.getElementById("text2");
15
16 // Create a new SVGLength object, with value=150.
17 var newLength1 = svg.createSVGLength();
18 newLength1.value = 150;
19 assert_equals(newLength1.value, 150);
20
21 // Check initial list state of text1.
22 assert_equals(text1.x.baseVal.numberOfItems, 5);
fs 2016/09/14 15:14:35 I think we an cut down on the boilerplate a bit he
Shanmuga Pandi 2016/09/15 06:18:18 Done.
23 assert_equals(text1.x.baseVal.getItem(0).value, 500);
24 assert_equals(text1.x.baseVal.getItem(1).value, 50);
25 assert_equals(text1.x.baseVal.getItem(2).value, 100);
26 assert_equals(text1.x.baseVal.getItem(3).value, 900);
27 assert_equals(text1.x.baseVal.getItem(4).value, 1000);
28 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(5); });
29
30 // Check initial list state of text2.
31 assert_equals(text2.x.baseVal.numberOfItems, 3);
32 assert_equals(text2.x.baseVal.getItem(0).value, 50);
33 assert_equals(text2.x.baseVal.getItem(1).value, 100);
34 assert_equals(text2.x.baseVal.getItem(2).value, 1000);
35 assert_throws("IndexSizeError", function() { text2.x.baseVal.getItem(3); });
36
37 // Append fourth item x=900 to the text1 x list.
38 assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value, te xt1.x.baseVal.getItem(5).value);
Srirama 2016/09/14 12:50:21 try using assert_object_equals instead of checking
Shanmuga Pandi 2016/09/14 13:28:17 assert_object_equals is not working for SVG TearOf
Srirama 2016/09/14 14:05:33 Acknowledged.
39 assert_equals(text1.x.baseVal.numberOfItems, 6);
40 assert_equals(text1.x.baseVal.getItem(0).value, 500);
41 assert_equals(text1.x.baseVal.getItem(1).value, 50);
42 assert_equals(text1.x.baseVal.getItem(2).value, 100);
43 assert_equals(text1.x.baseVal.getItem(3).value, 900);
44 assert_equals(text1.x.baseVal.getItem(4).value, 1000);
45 assert_equals(text1.x.baseVal.getItem(5).value, 900);
46 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(6); });
47
48 // Append first item x=500 to the text1 x list.
49 assert_equals(text1.x.baseVal.appendItem(text1.x.baseVal.getItem(0)).value, te xt1.x.baseVal.getItem(6).value);
Srirama 2016/09/14 12:50:21 ditto.
50 assert_equals(text1.x.baseVal.numberOfItems, 7);
51 assert_equals(text1.x.baseVal.getItem(0).value, 500);
52 assert_equals(text1.x.baseVal.getItem(1).value, 50);
53 assert_equals(text1.x.baseVal.getItem(2).value, 100);
54 assert_equals(text1.x.baseVal.getItem(3).value, 900);
55 assert_equals(text1.x.baseVal.getItem(4).value, 1000);
56 assert_equals(text1.x.baseVal.getItem(5).value, 900);
57 assert_equals(text1.x.baseVal.getItem(6).value, 500);
58 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(7); });
59
60 // Append 'newLength1' to the text1 x list.
61 assert_equals(text1.x.baseVal.appendItem(newLength1).value, text1.x.baseVal.ge tItem(7).value);
Srirama 2016/09/14 12:50:21 same here as well and in all other places.
62 assert_equals(text1.x.baseVal.numberOfItems, 8);
63 assert_equals(text1.x.baseVal.getItem(0).value, 500);
64 assert_equals(text1.x.baseVal.getItem(1).value, 50);
65 assert_equals(text1.x.baseVal.getItem(2).value, 100);
66 assert_equals(text1.x.baseVal.getItem(3).value, 900);
67 assert_equals(text1.x.baseVal.getItem(4).value, 1000);
68 assert_equals(text1.x.baseVal.getItem(5).value, 900);
69 assert_equals(text1.x.baseVal.getItem(6).value, 500);
70 assert_equals(text1.x.baseVal.getItem(7).value, 150);
71 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(8); });
72
73 // Append third and fourth item of the text1 x list to the text2 x list.
74 assert_equals(text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value, 10 0);
75 assert_equals(text2.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value, 90 0);
76 assert_equals(text1.x.baseVal.numberOfItems, 8);
77 assert_equals(text1.x.baseVal.getItem(0).value, 500);
78 assert_equals(text1.x.baseVal.getItem(1).value, 50);
79 assert_equals(text1.x.baseVal.getItem(2).value, 100);
80 assert_equals(text1.x.baseVal.getItem(3).value, 900);
81 assert_equals(text1.x.baseVal.getItem(4).value, 1000);
82 assert_equals(text1.x.baseVal.getItem(5).value, 900);
83 assert_equals(text1.x.baseVal.getItem(6).value, 500);
84 assert_equals(text1.x.baseVal.getItem(7).value, 150);
85 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(8); });
86 assert_equals(text2.x.baseVal.numberOfItems, 5);
87 assert_equals(text2.x.baseVal.getItem(0).value, 50);
88 assert_equals(text2.x.baseVal.getItem(1).value, 100);
89 assert_equals(text2.x.baseVal.getItem(2).value, 1000);
90 assert_equals(text2.x.baseVal.getItem(3).value, 100);
91 assert_equals(text2.x.baseVal.getItem(4).value, 900);
92 assert_throws("IndexSizeError", function() { text2.x.baseVal.getItem(5); });
93
94 var newLength2 = svg.createSVGLength();
95 newLength2.value = 150;
96 assert_equals(newLength2.value, 150);
97 text1.x.baseVal.clear();
98
99 // Shuffle around items in text1 and text2 list using appendItem, to get x=50, 100,150,... in both lists.
100 assert_equals(text1.x.baseVal.appendItem(text2.x.baseVal.getItem(0)).value, 50 );
101 assert_equals(text1.x.baseVal.appendItem(text2.x.baseVal.getItem(1)).value, 10 0);
102 assert_equals(text1.x.baseVal.appendItem(newLength2).value, 150);
103 text2.x.baseVal.clear();
104 assert_equals(text2.x.baseVal.appendItem(text1.x.baseVal.getItem(0)).value, 50 );
105 assert_equals(text2.x.baseVal.appendItem(text1.x.baseVal.getItem(1)).value, 10 0);
106 assert_equals(text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value, 15 0);
107 assert_equals(text1.x.baseVal.numberOfItems, 3);
108 assert_equals(text1.x.baseVal.getItem(0).value, 50);
109 assert_equals(text1.x.baseVal.getItem(1).value, 100);
110 assert_equals(text1.x.baseVal.getItem(2).value, 150);
111 assert_throws("IndexSizeError", function() { text1.x.baseVal.getItem(4); });
112 assert_equals(text2.x.baseVal.numberOfItems, 3);
113 assert_equals(text2.x.baseVal.getItem(0).value, 50);
114 assert_equals(text2.x.baseVal.getItem(1).value, 100);
115 assert_equals(text2.x.baseVal.getItem(2).value, 150);
116 assert_throws("IndexSizeError", function() { text2.x.baseVal.getItem(6); });
117 });
118 </script>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/svg/dom/SVGLengthList-getItem-expected.png ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml » ('j') | third_party/WebKit/LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml » ('J')

Powered by Google App Engine
This is Rietveld 408576698