Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2340723003: GN: add is_official_build (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
egdaniel, reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add is_official_build ... and use it to control debug symbols and SK_ALLOW_STATIC_GLOBAL_INITIALIZERS. This will most directly have the effect of disabling GLProgramsTest and a bunch of similar failing Vk tests on Android. Hopefully this makes the N7 trybot go green, keeping the N5 trybot green. Just running the N10 for fun. (is_official_build is how Chrome terms this sort of ReleaseForReal build.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340723003 Committed: https://skia.googlesource.com/skia/+/88a7ac0b2dad4e7d581eae2da19888aec9ba1693

Patch Set 1 #

Patch Set 2 : did that wrong #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gn/BUILD.gn View 2 chunks +10 lines, -8 lines 0 comments Download
M gn/BUILDCONFIG.gn View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 3 months ago (2016-09-14 17:22:22 UTC) #4
bsalomon
lgtm
4 years, 3 months ago (2016-09-14 17:29:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340723003/20001
4 years, 3 months ago (2016-09-14 17:30:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:16:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/88a7ac0b2dad4e7d581eae2da19888aec9ba1693

Powered by Google App Engine
This is Rietveld 408576698