Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: gn/BUILDCONFIG.gn

Issue 2340723003: GN: add is_official_build (Closed)
Patch Set: did that wrong Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gn/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gn/BUILDCONFIG.gn
diff --git a/gn/BUILDCONFIG.gn b/gn/BUILDCONFIG.gn
index e6a8b695ffe29f5a363baed6330ead29674b0646..79d06f400b05914371ca9a3947316d9dd4b099ae 100644
--- a/gn/BUILDCONFIG.gn
+++ b/gn/BUILDCONFIG.gn
@@ -6,12 +6,17 @@
# It's best to keep the names and defaults of is_foo flags consistent with Chrome.
declare_args() {
- is_debug = true
+ is_official_build = false
is_component_build = false
ndk = ""
ndk_api = 0 # 0 == picked automatically for target_cpu.
sanitize = ""
}
+declare_args() {
+ is_debug = !is_official_build
+}
+
+assert(!(is_debug && is_official_build))
# Platform detection
if (target_os == "") {
@@ -115,6 +120,9 @@ default_configs = [
if (!is_debug) {
default_configs += [ "//gn:release" ]
}
+if (!is_official_build) {
+ default_configs += [ "//gn:debug_symbols" ]
+}
set_defaults("executable") {
configs = default_configs + [ "//gn:executable" ]
« no previous file with comments | « gn/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698