dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
Committed: https://crrev.com/0ef935c2ea78249e96fb76fbc3bb91a79ab32afb
Cr-Commit-Position: refs/heads/master@{#418864}

[Daniel Erat, 2016-09-14 22:46:14]

derat@chromium.org changed reviewers:
+ hashimoto@chromium.org

[Daniel Erat, 2016-09-14 22:46:47]

(this change depends on https://codereview.chromium.org/2345593002/)

[hashimoto, 2016-09-15 06:12:05]

This lgtm.

BTW PowerManagerClient has a lot of variables to remember the current state.
This is different from many other D-Bus client classes which are simple C++
bindings of D-Bus objects and have almost no state.
Is PowerManagerClient safe to use from multiple processes when we switch to
mus+ash?

[Daniel Erat, 2016-09-15 13:49:09]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-09-15 13:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-09-15 13:55:48]

Description was changed from

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
==========

to

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
==========

[Daniel Erat, 2016-09-15 14:02:20]

On 2016/09/15 06:12:05, hashimoto wrote:
> This lgtm.
> 
> BTW PowerManagerClient has a lot of variables to remember the current state.
> This is different from many other D-Bus client classes which are simple C++
> bindings of D-Bus objects and have almost no state.
> Is PowerManagerClient safe to use from multiple processes when we switch to
> mus+ash?

[cc-ing james since this is of interest to him.]

you're referring to the functionality that i'm testing here, right? all of that
is related to suspend delays. if both ash and chrome end up needing to register
suspend delays, we'll need the code in both processes. if a process doesn't need
a suspend delay, running this code shouldn't break anything (but we'll still
want to avoid it since it means powerd is waiting for one more process to
confirm that it's ready for suspend).

i mentioned this in
http://docs/document/d/1iMfe_ufn3xgtg8kF7yXQ-LRQvrQCfZP4H1QDyOaIY74/edit ("It
also registers for notifications of imminent suspend events, but powerd already
supports multiple processes doing this.") but will add more details.

[commit-bot: I haz the power, 2016-09-15 14:32:54]

Description was changed from

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
==========

to

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
==========

[commit-bot: I haz the power, 2016-09-15 14:32:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 14:34:46]

Description was changed from

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912
==========

to

==========
dbus: Mock MockObjectProxy::SetNameOwnerChangedCallback().

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912

Committed: https://crrev.com/0ef935c2ea78249e96fb76fbc3bb91a79ab32afb
Cr-Commit-Position: refs/heads/master@{#418864}
==========

[commit-bot: I haz the power, 2016-09-15 14:34:48]

Patchset 1 (id:??) landed as
https://crrev.com/0ef935c2ea78249e96fb76fbc3bb91a79ab32afb
Cr-Commit-Position: refs/heads/master@{#418864}

[James Cook, 2016-09-15 16:10:32]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-09-15 16:10:32]

Thanks for the heads-up.