Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2340683002: Advance image animations when drawing as shaders (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews, krit, shans, rjwright, blink-reviews-platform-graphics_chromium.org, blink-reviews-animation_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), darktears, blink-reviews, drott+blinkwatch_chromium.org, danakj+watch_chromium.org, rwlbuis, ajuma+watch_chromium.org, Stephen Chennney, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Advance image animations when drawing as shaders Currently, we refresh image animations from their draw() impl. But the rounded-rect fast path introduced in http://crrev.com/1949253004 draws images via shaders, so it may never call Image::draw() to advance animations. Update applyShader() to refresh the animations explicitly, similar to the draw() case. BUG=644112 Committed: https://crrev.com/604a9c1f58454572d2e4c3680e913de37723410b Cr-Commit-Position: refs/heads/master@{#418544}

Patch Set 1 #

Patch Set 2 : refresh in applyShader() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A + third_party/WebKit/LayoutTests/fast/backgrounds/animated-gif-as-background-rounded.html View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/animated-gif-as-background-rounded-expected.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
f(malita)
4 years, 3 months ago (2016-09-14 04:40:35 UTC) #8
Stephen Chennney
lgtm
4 years, 3 months ago (2016-09-14 12:54:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340683002/20001
4 years, 3 months ago (2016-09-14 13:41:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 13:46:22 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 13:49:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/604a9c1f58454572d2e4c3680e913de37723410b
Cr-Commit-Position: refs/heads/master@{#418544}

Powered by Google App Engine
This is Rietveld 408576698