Modifies logic for computing drop down menu arrow's dimensions and how it is drawn.

third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp

 /*
  * Copyright (C) 2007 Apple Inc.
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Collabora Ltd.
  * Copyright (C) 2008, 2009 Google Inc.
  * Copyright (C) 2009 Kenneth Rohde Christiansen
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 244 matching lines @@
 
 void ThemePainterDefault::setupMenuListArrow(const LayoutBox& box, const IntRect& rect, WebThemeEngine::ExtraParams& extraParams)
 {
     const int right = rect.x() + rect.width();
     const int middle = rect.y() + rect.height() / 2;
 
     extraParams.menuList.arrowY = middle;
     if (useMockTheme()) {
         // The size and position of the drop-down button is different between
         // the mock theme and the regular aura theme.
-        int spacingTop = (box.borderTop() + box.paddingTop()).toInt();
-        int spacingBottom = (box.borderBottom() + box.paddingBottom()).toInt();
-        int spacingRight = (box.borderRight() + box.paddingRight()).toInt();
-        extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) ? rect.x() + 4 + spacingRight: right - 10 - spacingRight;
-        extraParams.menuList.arrowSize = rect.height() - spacingBottom - spacingTop;
+        int extraPadding = 3 * box.styleRef().effectiveZoom();

[oshima, 2016/09/17 01:31:21]

define const for 3 and explain what's in CSS pixel for extra padding.

[malaykeshav, 2016/09/19 18:09:27]

Done

+        // The width available for the arrow is based on the padding provided
+        // in the child LayoutBox.
+        int arrowBoxWidth = ((box.styleRef().direction() == RTL) ?
+            box.firstChildBox()->paddingLeft() :
+            box.firstChildBox()->paddingRight()).toInt();
+        int arrowSize = std::min(arrowBoxWidth, rect.height()) - 2 * extraPadding;

[oshima, 2016/09/17 01:31:21]

80 chars

[malaykeshav, 2016/09/19 18:09:27]

This file doesn't follow the 80 char limit. git cl format puts everything in a
single line.

+        extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) ?
+            rect.x() + extraPadding + (arrowSize / 2):
+            right - (arrowSize / 2) - extraPadding;
+        extraParams.menuList.arrowSize = arrowSize;
     } else {
         const int arrowSize = 6;
         const int arrowPadding = 6;
         extraParams.menuList.arrowX = (box.styleRef().direction() == RTL)
             ? rect.x() + arrowPadding * box.styleRef().effectiveZoom() + box.borderLeft()
             : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom() - box.borderRight();
         extraParams.menuList.arrowSize = arrowSize * box.styleRef().effectiveZoom();
     }
     extraParams.menuList.arrowColor = box.resolveColor(CSSPropertyColor).rgb();
 }
@@ skipping 112 matching lines @@
         cancelButtonSize, cancelButtonSize);
     IntRect paintingRect = convertToPaintingRect(inputLayoutBox, cancelButtonObject, cancelButtonRect, r);
 
     DEFINE_STATIC_REF(Image, cancelImage, (Image::loadPlatformResource("searchCancel")));
     DEFINE_STATIC_REF(Image, cancelPressedImage, (Image::loadPlatformResource("searchCancelPressed")));
     paintInfo.context.drawImage(LayoutTheme::isPressed(cancelButtonObject) ? cancelPressedImage : cancelImage, paintingRect);
     return false;
 }
 
 } // namespace blink