Issue 2340543002: Merge M54: "Clear reference time after SetMediaTime in video-only time source."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2340543002: Merge M54: "Clear reference time after SetMediaTime in video-only time source." (Closed)

Created:
4 years, 3 months ago by DaleCurtis

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Merge M54: "Clear reference time after SetMediaTime in video-only time source." Without this, after a seek we may remove valid frames because we think we are in an underflow state. BUG=642761 TEST=new unittest. Review-Url: https://codereview.chromium.org/2322393002 Cr-Commit-Position: refs/heads/master@{#417678} (cherry picked from commit 983881fde249f0bcc6e63426237016a98536d1ea) Committed: https://chromium.googlesource.com/chromium/src/+/ff96ab1a1beaa930cb4db6b43c4068066d061cff

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	media/base/time_source.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	media/base/wall_clock_time_source.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/wall_clock_time_source_unittest.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

DaleCurtis

4 years, 3 months ago (2016-09-13 18:34:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff96ab1a1beaa930cb4db6b43c4068066d061cff.