Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2322393002: Clear reference time after SetMediaTime in video-only time source. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear reference time after SetMediaTime in video-only time source. Without this, after a seek we may remove valid frames because we think we are in an underflow state. BUG=642761 TEST=new unittest. Committed: https://crrev.com/983881fde249f0bcc6e63426237016a98536d1ea Cr-Commit-Position: refs/heads/master@{#417678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M media/base/time_source.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/wall_clock_time_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/wall_clock_time_source_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
DaleCurtis
4 years, 3 months ago (2016-09-09 18:11:14 UTC) #2
watk
lgtm
4 years, 3 months ago (2016-09-09 18:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322393002/1
4 years, 3 months ago (2016-09-09 18:16:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 20:05:26 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:07:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/983881fde249f0bcc6e63426237016a98536d1ea
Cr-Commit-Position: refs/heads/master@{#417678}

Powered by Google App Engine
This is Rietveld 408576698