Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2340523002: [Merge to 54] Fixup CPDFSDK_PageView and CPDF_Page interactions. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2840
Project:
pdfium
Visibility:
Public.

Description

[Merge to 54] Fixup CPDFSDK_PageView and CPDF_Page interactions. There are several issues when CPDFSDK_PageView and CPDF_Page interact, especially around deletion. This Cl fixes up several places where things go wrong working with these objects. BUG=chromium:632709 R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2319663002 Committed: https://pdfium.googlesource.com/pdfium/+/5f909eefc176feb7c8cf97afe38982025e9238cd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M fpdfsdk/fpdfview.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 4 chunks +11 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +3 lines, -2 lines 1 comment Download
M fpdfsdk/javascript/Field.cpp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. https://codereview.chromium.org/2340523002/diff/1/fpdfsdk/include/fsdk_mgr.h File fpdfsdk/include/fsdk_mgr.h (right): https://codereview.chromium.org/2340523002/diff/1/fpdfsdk/include/fsdk_mgr.h#newcode626 fpdfsdk/include/fsdk_mgr.h:626: bool m_bOwnsPage; There was a merge conflict here ...
4 years, 3 months ago (2016-09-13 18:23:33 UTC) #2
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-13 18:39:36 UTC) #3
dsinclair
4 years, 3 months ago (2016-09-13 18:50:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f909eefc176feb7c8cf97afe38982025e9238cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698