Fixup CPDFSDK_PageView and CPDF_Page interactions.

Fixup CPDFSDK_PageView and CPDF_Page interactions.

There are several issues when CPDFSDK_PageView and CPDF_Page interact,
especially around deletion. This Cl fixes up several places where things
go wrong working with these objects.

BUG=chromium:632709
Committed: https://pdfium.googlesource.com/pdfium/+/1df1efa3921841fb5fc7fc15e8112eed4375de9f

[dsinclair, 2016-09-07 15:48:20]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:48:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:01:04]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-07 16:01:51]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-07 16:01:51]

PTAL.

[Tom Sepez, 2016-09-07 16:17:40]

lgtm

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:672: pPage->Release();
follow-on: we should make both kinds of pages be retain/release.

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:678: pPageView->TakeOverPage();
nit: someday, lets rename this to TakePageOwnership() to match OwnsPage().

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:302: if (it == m_pageMap.end())
nit: maybe ? operator

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:526: if (m_bTakeOverPage)
nit: someday call it m_bOwnsPage

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/include/fsdk_mgr.h
File fpdfsdk/include/fsdk_mgr.h (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:622: FX_BOOL m_bTakeOverPage;
nit: can we make this a bool while we're at it?

[dsinclair, 2016-09-07 16:36:36]

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:672: pPage->Release();
On 2016/09/07 16:17:40, Tom Sepez wrote:
> follow-on: we should make both kinds of pages be retain/release.

Acknowledged. I'd like to do the same thing as I've been working on with
Document to fold the two types together.

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcod...
fpdfsdk/fpdfview.cpp:678: pPageView->TakeOverPage();
On 2016/09/07 16:17:40, Tom Sepez wrote:
> nit: someday, lets rename this to TakePageOwnership() to match OwnsPage().

Done.

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:302: if (it == m_pageMap.end())
On 2016/09/07 16:17:40, Tom Sepez wrote:
> nit: maybe ? operator

Done.

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:526: if (m_bTakeOverPage)
On 2016/09/07 16:17:40, Tom Sepez wrote:
> nit: someday call it m_bOwnsPage

Done.

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/include/fsdk_mgr.h
File fpdfsdk/include/fsdk_mgr.h (right):

https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:622: FX_BOOL m_bTakeOverPage;
On 2016/09/07 16:17:40, Tom Sepez wrote:
> nit: can we make this a bool while we're at it?

Done.

[dsinclair, 2016-09-07 16:36:39]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-07 16:36:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2319663002/#ps20001
(title: "review feedback")

[commit-bot: I haz the power, 2016-09-07 16:36:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:55:39]

Description was changed from

==========
Fixup CPDFSDK_PageView and CPDF_Page interactions.

There are several issues when CPDFSDK_PageView and CPDF_Page interact,
especially around deletion. This Cl fixes up several places where things
go wrong working with these objects.

BUG=chromium:632709
==========

to

==========
Fixup CPDFSDK_PageView and CPDF_Page interactions.

There are several issues when CPDFSDK_PageView and CPDF_Page interact,
especially around deletion. This Cl fixes up several places where things
go wrong working with these objects.

BUG=chromium:632709

Committed:
https://pdfium.googlesource.com/pdfium/+/1df1efa3921841fb5fc7fc15e8112eed4375...
==========

[commit-bot: I haz the power, 2016-09-07 16:55:40]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1df1efa3921841fb5fc7fc15e8112eed4375...