Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2319663002: Fixup CPDFSDK_PageView and CPDF_Page interactions. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fixup CPDFSDK_PageView and CPDF_Page interactions. There are several issues when CPDFSDK_PageView and CPDF_Page interact, especially around deletion. This Cl fixes up several places where things go wrong working with these objects. BUG=chromium:632709 Committed: https://pdfium.googlesource.com/pdfium/+/1df1efa3921841fb5fc7fc15e8112eed4375de9f

Patch Set 1 #

Total comments: 10

Patch Set 2 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M fpdfsdk/fpdfview.cpp View 1 1 chunk +14 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 4 chunks +11 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-07 16:01:51 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp File fpdfsdk/fpdfview.cpp (right): https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcode672 fpdfsdk/fpdfview.cpp:672: pPage->Release(); follow-on: we should make both kinds of ...
4 years, 3 months ago (2016-09-07 16:17:40 UTC) #7
dsinclair
https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp File fpdfsdk/fpdfview.cpp (right): https://codereview.chromium.org/2319663002/diff/1/fpdfsdk/fpdfview.cpp#newcode672 fpdfsdk/fpdfview.cpp:672: pPage->Release(); On 2016/09/07 16:17:40, Tom Sepez wrote: > follow-on: ...
4 years, 3 months ago (2016-09-07 16:36:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319663002/20001
4 years, 3 months ago (2016-09-07 16:36:42 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:55:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1df1efa3921841fb5fc7fc15e8112eed4375...

Powered by Google App Engine
This is Rietveld 408576698