|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Greg Levin Modified:
3 years, 8 months ago Reviewers:
Alexander Alekseev CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet default focus on offline signin page
BUG=539616
TEST=with device offline at login, click "Add person". At the "Network
not available" screen, click "sign in as an existing user." When the
login page comes up, the "Enter your email" field should have focus.
Just needed to hit the field with a focus event after the page was ready.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2340463002
Cr-Commit-Position: refs/heads/master@{#462090}
Committed: https://chromium.googlesource.com/chromium/src/+/77dcc0a097f2cddb81d034dd3c60084c5a225571
Patch Set 1 #Patch Set 2 : Merge #Messages
Total messages: 23 (14 generated)
Description was changed from ========== Set default focus on offline signin page BUG=539616 TEST=with device offline at login, click "Add person". At the "Network not available" screen, click "sign in as an existing user." When the login page comes up, the "Enter your email" field should have focus. Just needed to hit the field with a focus event after the page was ready. ========== to ========== Set default focus on offline signin page BUG=539616 TEST=with device offline at login, click "Add person". At the "Network not available" screen, click "sign in as an existing user." When the login page comes up, the "Enter your email" field should have focus. Just needed to hit the field with a focus event after the page was ready. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
glevin@chromium.org changed reviewers: + alemate@chromium.org
Please have a look!
lgtm
The CQ bit was checked by glevin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by glevin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/09/13 18:59:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) I don't believe that this failure is caused by this CL. I've documented the failure (seen independently on tryserver) in https://bugs.chromium.org/p/chromium/issues/detail?id=646437.
The CQ bit was checked by glevin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by glevin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org Link to the patchset: https://codereview.chromium.org/2340463002/#ps20001 (title: "Merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491406458697350,
"parent_rev": "3cda020e6fa6fe0c9fbdb9a3589520e786425826", "commit_rev":
"77dcc0a097f2cddb81d034dd3c60084c5a225571"}
Message was sent while issue was closed.
Description was changed from ========== Set default focus on offline signin page BUG=539616 TEST=with device offline at login, click "Add person". At the "Network not available" screen, click "sign in as an existing user." When the login page comes up, the "Enter your email" field should have focus. Just needed to hit the field with a focus event after the page was ready. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Set default focus on offline signin page BUG=539616 TEST=with device offline at login, click "Add person". At the "Network not available" screen, click "sign in as an existing user." When the login page comes up, the "Enter your email" field should have focus. Just needed to hit the field with a focus event after the page was ready. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2340463002 Cr-Commit-Position: refs/heads/master@{#462090} Committed: https://chromium.googlesource.com/chromium/src/+/77dcc0a097f2cddb81d034dd3c60... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/77dcc0a097f2cddb81d034dd3c60... |
