Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2340463002: Set default focus on offline signin page (Closed)

Created:
4 years, 3 months ago by Greg Levin
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set default focus on offline signin page BUG=539616 TEST=with device offline at login, click "Add person". At the "Network not available" screen, click "sign in as an existing user." When the login page comes up, the "Enter your email" field should have focus. Just needed to hit the field with a focus event after the page was ready. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2340463002 Cr-Commit-Position: refs/heads/master@{#462090} Committed: https://chromium.googlesource.com/chromium/src/+/77dcc0a097f2cddb81d034dd3c60084c5a225571

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Greg Levin
Please have a look!
4 years, 3 months ago (2016-09-13 16:08:05 UTC) #3
Alexander Alekseev
lgtm
4 years, 3 months ago (2016-09-13 16:18:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463002/1
4 years, 3 months ago (2016-09-13 16:33:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/277368)
4 years, 3 months ago (2016-09-13 17:20:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463002/1
4 years, 3 months ago (2016-09-13 17:41:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/277464)
4 years, 3 months ago (2016-09-13 18:59:54 UTC) #12
Greg Levin
On 2016/09/13 18:59:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-14 16:06:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463002/20001
3 years, 8 months ago (2017-04-05 15:34:57 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:00:58 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77dcc0a097f2cddb81d034dd3c60...

Powered by Google App Engine
This is Rietveld 408576698