Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2340403002: DevTools: Don't update ViewportControl selection if there is no selection (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't update ViewportControl selection if there is no selection BUG=none Committed: https://crrev.com/fd6b4f5b4372795ed85b3653beb41f1681904f24 Cr-Commit-Position: refs/heads/master@{#419055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2339293003 Patch 20001
Issue 2339293003 Patch 40001

Messages

Total messages: 8 (3 generated)
einbinder
You said you liked one line patches.
4 years, 3 months ago (2016-09-15 19:47:55 UTC) #2
lushnikov
lgtm
4 years, 3 months ago (2016-09-15 20:46:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340403002/1
4 years, 3 months ago (2016-09-15 22:55:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 00:34:14 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:37:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd6b4f5b4372795ed85b3653beb41f1681904f24
Cr-Commit-Position: refs/heads/master@{#419055}

Powered by Google App Engine
This is Rietveld 408576698