Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2339293003: DevTools: Buffer ViewportController to prevent whitespace on scroll. (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
lushnikov, luoe
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Buffer ViewportController to prevent whitespace on scroll. This prevents the user from seeing the console messages load in as they scroll. BUG=none Committed: https://crrev.com/867f2dbb4ec7297619bf186b02d959b2f2f56ade Cr-Commit-Position: refs/heads/master@{#419090}

Patch Set 1 #

Patch Set 2 : upstream #

Total comments: 1

Patch Set 3 : Fix math error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -42 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 1 2 14 chunks +52 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
einbinder
ptal
4 years, 3 months ago (2016-09-15 20:45:30 UTC) #2
lushnikov
https://codereview.chromium.org/2339293003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right): https://codereview.chromium.org/2339293003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js#newcode433 third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:433: this._firstActiveIndex = Math.max(Array.prototype.lowerBound.call(this._cumulativeHeights, visibleFrom + 1 - activeHeight / ...
4 years, 3 months ago (2016-09-15 20:53:08 UTC) #3
lushnikov
lgtm % comment
4 years, 3 months ago (2016-09-15 20:53:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339293003/40001
4 years, 3 months ago (2016-09-16 00:44:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 03:16:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 03:20:40 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/867f2dbb4ec7297619bf186b02d959b2f2f56ade
Cr-Commit-Position: refs/heads/master@{#419090}

Powered by Google App Engine
This is Rietveld 408576698