Make Range methods to work with detached node

Make Range methods to work with detached node

This patch makes Range methods, setEndAfter, setEndBefore, setStartAfter, setStartBefore, selectNode and surroundContents, to work with detached node as the spec, http://dom.spec.whatwg.org) 

BUG=275848
TEST=LayoutTests/fast/dom/Range/range-on-detached-node.html, LayoutTests/fast/dom/Range/surroundContents-for-detached-node.html
R=mkwst@chromium.org, tkent@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156752

[yosin_UTC9, 2013-08-26 08:49:38]

Could you review this patch?
Thanks in advance.

This patch is a replacement of https://codereview.chromium.org/23071006/, which
changed Range::selectNode() and Range::surroundContents(), to support detach
node for set{End,Start}{After,Before} in addition to selectNode() and
surrondContents().

[Mike West, 2013-08-26 10:03:44]

code change LGTM, but again, please get tkent's signoff since he knows this code
better than I.

Thanks!

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.cpp#new...
Source/core/dom/Range.cpp:1172: return;
Can you add reasonable error messages here, as you've done on #1180?

[tkent, 2013-08-26 22:37:40]

lgtm

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.h
File Source/core/dom/Range.h (right):

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.h#newco...
Source/core/dom/Range.h:159: void checkNodeBA(Node*, ExceptionState&, const
char*) const;
It's hard to imagine what the "const char*" argument is.  Please add an argument
name or a comment.

[yosin_UTC9, 2013-08-27 02:18:55]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.cpp#new...
Source/core/dom/Range.cpp:1172: return;
On 2013/08/26 10:03:44, Mike West wrote:
> Can you add reasonable error messages here, as you've done on #1180?
I would like to minimize change. So, Could you file a ticker for this and assign
to me? I'll do that.
Thanks in advance.

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.h
File Source/core/dom/Range.h (right):

https://codereview.chromium.org/23404003/diff/1/Source/core/dom/Range.h#newco...
Source/core/dom/Range.h:159: void checkNodeBA(Node*, ExceptionState&, const
char*) const;
On 2013/08/26 22:37:41, tkent wrote:
> It's hard to imagine what the "const char*" argument is.  Please add an
argument
> name or a comment.

Done.

[yosin_UTC9, 2013-08-27 02:19:44]

Committed patchset #2 manually as r156752 (presubmit successful).