Make Range methods to work with detached node

Source/core/dom/Range.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Gunnstein Lye (gunnstein@netcom.no)
  * (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
  * (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/dom/Range.h"
 
+#include "bindings/v8/ExceptionMessages.h"
 #include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/ClientRect.h"
 #include "core/dom/ClientRectList.h"
 #include "core/dom/DocumentFragment.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/Node.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/NodeWithIndex.h"
 #include "core/dom/ProcessingInstruction.h"
@@ skipping 1114 matching lines @@
             Node* childBefore = n->childNode(offset - 1);
             if (!childBefore)
                 es.throwDOMException(IndexSizeError);
             return childBefore;
         }
     }
     ASSERT_NOT_REACHED();
     return 0;
 }
 
-void Range::checkNodeBA(Node* n, ExceptionState& es) const
+void Range::checkNodeBA(Node* n, ExceptionState& es, const char* methodName) const
 {
+    if (!m_start.container()) {
+        es.throwDOMException(InvalidStateError);
+        return;
+    }
+
+    if (!n) {
+        es.throwDOMException(NotFoundError);
+        return;
+    }
+
     // InvalidNodeTypeError: Raised if the root container of refNode is not an
     // Attr, Document, DocumentFragment or ShadowRoot node, or part of a SVG shadow DOM tree,
     // or if refNode is a Document, DocumentFragment, ShadowRoot, Attr, Entity, or Notation node.
 
+    if (!n->parentNode()) {
+        es.throwDOMException(InvalidNodeTypeError, ExceptionMessages::failedToExecute(methodName, "Range", "the given Node has no parent."));
+        return;
+    }
+
     switch (n->nodeType()) {
         case Node::ATTRIBUTE_NODE:
         case Node::DOCUMENT_FRAGMENT_NODE:
         case Node::DOCUMENT_NODE:
         case Node::ENTITY_NODE:
         case Node::NOTATION_NODE:
             es.throwDOMException(InvalidNodeTypeError);
             return;
         case Node::CDATA_SECTION_NODE:
         case Node::COMMENT_NODE:
         case Node::DOCUMENT_TYPE_NODE:
         case Node::ELEMENT_NODE:
         case Node::PROCESSING_INSTRUCTION_NODE:
         case Node::TEXT_NODE:
         case Node::XPATH_NAMESPACE_NODE:
             break;
     }
 
     Node* root = n;
     while (ContainerNode* parent = root->parentNode())
         root = parent;
 
     switch (root->nodeType()) {
         case Node::ATTRIBUTE_NODE:
         case Node::DOCUMENT_NODE:
         case Node::DOCUMENT_FRAGMENT_NODE:
+        case Node::ELEMENT_NODE:
             break;
         case Node::CDATA_SECTION_NODE:
         case Node::COMMENT_NODE:
         case Node::DOCUMENT_TYPE_NODE:
-        case Node::ELEMENT_NODE:
         case Node::ENTITY_NODE:
         case Node::NOTATION_NODE:
         case Node::PROCESSING_INSTRUCTION_NODE:
         case Node::TEXT_NODE:
         case Node::XPATH_NAMESPACE_NODE:
             es.throwDOMException(InvalidNodeTypeError);
             return;
     }
 }
 
 PassRefPtr<Range> Range::cloneRange(ExceptionState& es) const
 {
     if (!m_start.container()) {
         es.throwDOMException(InvalidStateError);
         return 0;
     }
 
     return Range::create(m_ownerDocument, m_start.container(), m_start.offset(), m_end.container(), m_end.offset());
 }
 
 void Range::setStartAfter(Node* refNode, ExceptionState& es)
 {
-    if (!m_start.container()) {
-        es.throwDOMException(InvalidStateError);
-        return;
-    }
-
-    if (!refNode) {
-        es.throwDOMException(NotFoundError);
-        return;
-    }
-
-    checkNodeBA(refNode, es);
+    checkNodeBA(refNode, es, "setStartAfter");
     if (es.hadException())
         return;
 
     setStart(refNode->parentNode(), refNode->nodeIndex() + 1, es);
 }
 
 void Range::setEndBefore(Node* refNode, ExceptionState& es)
 {
-    if (!m_start.container()) {
-        es.throwDOMException(InvalidStateError);
-        return;
-    }
-
-    if (!refNode) {
-        es.throwDOMException(NotFoundError);
-        return;
-    }
-
-    checkNodeBA(refNode, es);
+    checkNodeBA(refNode, es, "setEndBefore");
     if (es.hadException())
         return;
 
     setEnd(refNode->parentNode(), refNode->nodeIndex(), es);
 }
 
 void Range::setEndAfter(Node* refNode, ExceptionState& es)
 {
-    if (!m_start.container()) {
-        es.throwDOMException(InvalidStateError);
-        return;
-    }
-
-    if (!refNode) {
-        es.throwDOMException(NotFoundError);
-        return;
-    }
-
-    checkNodeBA(refNode, es);
+    checkNodeBA(refNode, es, "setEndAfter");
     if (es.hadException())
         return;
 
     setEnd(refNode->parentNode(), refNode->nodeIndex() + 1, es);
 }
 
 void Range::selectNode(Node* refNode, ExceptionState& es)
 {
     if (!m_start.container()) {
         es.throwDOMException(InvalidStateError);
         return;
     }
 
     if (!refNode) {
         es.throwDOMException(NotFoundError);
         return;
     }
 
+    if (!refNode->parentNode()) {
+        es.throwDOMException(InvalidNodeTypeError, ExceptionMessages::failedToExecute("selectNode", "Range", "the given Node has no parent."));
+        return;
+    }
+
     // InvalidNodeTypeError: Raised if an ancestor of refNode is an Entity, Notation or
     // DocumentType node or if refNode is a Document, DocumentFragment, ShadowRoot, Attr, Entity, or Notation
     // node.
     for (ContainerNode* anc = refNode->parentNode(); anc; anc = anc->parentNode()) {
         switch (anc->nodeType()) {
             case Node::ATTRIBUTE_NODE:
             case Node::CDATA_SECTION_NODE:
             case Node::COMMENT_NODE:
             case Node::DOCUMENT_FRAGMENT_NODE:
             case Node::DOCUMENT_NODE:
@@ skipping 24 matching lines @@
         case Node::DOCUMENT_NODE:
         case Node::ENTITY_NODE:
         case Node::NOTATION_NODE:
             es.throwDOMException(InvalidNodeTypeError);
             return;
     }
 
     if (m_ownerDocument != refNode->document())
         setDocument(refNode->document());
 
-    setStartBefore(refNode, es);
-    if (es.hadException())
-        return;
-    setEndAfter(refNode, es);
+    setStartBefore(refNode);
+    setEndAfter(refNode);
 }
 
 void Range::selectNodeContents(Node* refNode, ExceptionState& es)
 {
     if (!m_start.container()) {
         es.throwDOMException(InvalidStateError);
         return;
     }
 
     if (!refNode) {
@@ skipping 109 matching lines @@
     if (es.hadException())
         return;
     newParent->appendChild(fragment.release(), es);
     if (es.hadException())
         return;
     selectNode(newParent.get(), es);
 }
 
 void Range::setStartBefore(Node* refNode, ExceptionState& es)
 {
-    if (!m_start.container()) {
-        es.throwDOMException(InvalidStateError);
-        return;
-    }
-
-    if (!refNode) {
-        es.throwDOMException(NotFoundError);
-        return;
-    }
-
-    checkNodeBA(refNode, es);
+    checkNodeBA(refNode, es, "setStartBefore");
     if (es.hadException())
         return;
 
     setStart(refNode->parentNode(), refNode->nodeIndex(), es);
 }
 
 void Range::checkDeleteExtract(ExceptionState& es)
 {
     if (!m_start.container()) {
         es.throwDOMException(InvalidStateError);
@@ skipping 430 matching lines @@
 
 void showTree(const WebCore::Range* range)
 {
     if (range && range->boundaryPointsValid()) {
         range->startContainer()->showTreeAndMark(range->startContainer(), "S", range->endContainer(), "E");
         fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset(), range->endOffset());
     }
 }
 
 #endif