Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/testing/OriginTrialsTest.idl

Issue 2340323002: Add Origin Trials Test interface, rather than attaching trials directly to internals. (Closed)
Patch Set: IDL-backed methods are not static on full interfaces Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
diff --git a/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl b/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
new file mode 100644
index 0000000000000000000000000000000000000000..90d17da8fc477b614dc677794c0f352ad5b2aaa6
--- /dev/null
+++ b/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
@@ -0,0 +1,13 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+[
+] interface OriginTrialsTest {
haraken 2016/09/16 13:48:46 Remove the empty []. (foolip@ is landing a change
iclelland 2016/09/16 14:38:42 Thanks, done! I saw that this morning when I tried
+ [OriginTrialEnabled=OriginTrialsSampleAPI] readonly attribute boolean normalAttribute;
+ [OriginTrialEnabled=OriginTrialsSampleAPI] static readonly attribute boolean staticAttribute;
+ [CallWith=ScriptState, RaisesException] readonly attribute boolean throwingAttribute;
chasej 2016/09/16 15:17:02 Nit: Maybe add a comment explaining that this thro
iclelland 2016/09/16 15:59:47 Done.
+ readonly attribute boolean unconditionalAttribute;
+ [OriginTrialEnabled=OriginTrialsSampleAPI, ImplementedAs=unconditionalAttribute] readonly attribute boolean bindingsTest;
+ [OriginTrialEnabled=OriginTrialsSampleAPI] const unsigned short CONSTANT = 1;
+};

Powered by Google App Engine
This is Rietveld 408576698