third_party/WebKit/Source/core/testing/OriginTrialsTest.idl - Issue 2340323002: Add Origin Trials Test interface, rather than attaching trials directly to internals.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/OriginTrialsTest.idl

Issue 2340323002: Add Origin Trials Test interface, rather than attaching trials directly to internals. (Closed)

Patch Set: IDL-backed methods are not static on full interfaces Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/testing/OriginTrialsTest.h ('K') | « third_party/WebKit/Source/core/testing/OriginTrialsTest.cpp ('k') | third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.h » ('j') | third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 ] interface OriginTrialsTest {
	haraken 2016/09/16 13:48:46 Remove the empty []. (foolip@ is landing a change Remove the empty []. (foolip@ is landing a change to forbid it.) iclelland 2016/09/16 14:38:42 Thanks, done! I saw that this morning when I tried Show quoted text On 2016/09/16 13:48:46, haraken wrote: > > Remove the empty []. (foolip@ is landing a change to forbid it.) Thanks, done! I saw that this morning when I tried to rebase.
	7 [OriginTrialEnabled=OriginTrialsSampleAPI] readonly attribute boolean normal Attribute;

	8 [OriginTrialEnabled=OriginTrialsSampleAPI] static readonly attribute boolean staticAttribute;

	9 [CallWith=ScriptState, RaisesException] readonly attribute boolean throwingA ttribute;
	chasej 2016/09/16 15:17:02 Nit: Maybe add a comment explaining that this thro Nit: Maybe add a comment explaining that this throws when trial is not enabled (i.e. use native enabled check)? I had to look at the .cpp to figure out the intent. iclelland 2016/09/16 15:59:47 Done. Show quoted text On 2016/09/16 15:17:02, chasej wrote: > Nit: Maybe add a comment explaining that this throws when trial is not enabled > (i.e. use native enabled check)? I had to look at the .cpp to figure out the > intent. Done.
	10 readonly attribute boolean unconditionalAttribute;

	11 [OriginTrialEnabled=OriginTrialsSampleAPI, ImplementedAs=unconditionalAttrib ute] readonly attribute boolean bindingsTest;

	12 [OriginTrialEnabled=OriginTrialsSampleAPI] const unsigned short CONSTANT = 1 ;

	13 };

OLD	NEW