Issue 23403007: Rewrite test language/constructor_negative_test to a multi-test

Issue 23403007: Rewrite test language/constructor_negative_test to a multi-test (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rewrite test language/constructor_negative_test to a multi-test R=ahe@google.com BUG=http://dartbug.org/11586 Committed: https://code.google.com/p/dart/source/detail?r=26686

Patch Set 2 : Addressed review comments #

Patch Set 3 : Correct base #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -39 lines)			Patch
A +	tests/language/constructor_call_as_function_test.dart	View	1	1 chunk	+1 line, -8 lines	0 comments	Download
D	tests/language/constructor_negative_test.dart	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	2	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/23403007/diff/1/tests/language/constructor_call_as_function_test.dart File tests/language/constructor_call_as_function_test.dart (right): https://codereview.chromium.org/23403007/diff/1/tests/language/constructor_call_as_function_test.dart#newcode17 tests/language/constructor_call_as_function_test.dart:17: Point p = Point(1, 2); /// 01: static ...

7 years, 3 months ago (2013-08-26 14:06:33 UTC) #2

Søren Gjesse

Committed patchset #3 manually as r26686 (presubmit successful).

7 years, 3 months ago (2013-08-27 06:38:30 UTC) #3

Søren Gjesse

7 years, 1 month ago (2013-10-30 11:40:30 UTC) #4

Message was sent while issue was closed.

Sending old comments.

https://codereview.chromium.org/23403007/diff/1/tests/language/constructor_ca...
File tests/language/constructor_call_as_function_test.dart (right):

https://codereview.chromium.org/23403007/diff/1/tests/language/constructor_ca...
tests/language/constructor_call_as_function_test.dart:17: Point p = Point(1, 2);
 /// 01: static type warning, runtime error
On 2013/08/26 14:06:33, ahe wrote:
> Inline this in main?

Done.

https://codereview.chromium.org/23403007/diff/1/tests/language/constructor_ca...
tests/language/constructor_call_as_function_test.dart:22:
ConstructorTest.testMain();  /// 01: continued
On 2013/08/26 14:06:33, ahe wrote:
> Don't need "continued" here.

Line removed with the call inlined in main.

Expand Messages | Collapse Messages