Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 23403002: Pass _replay_host to web-page-replay via --host. (Closed)

Created:
7 years, 4 months ago by szym
Modified:
7 years, 3 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Pass _replay_host to web-page-replay via --host. Update IsStarted check to be aware of --host. BUG=272381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/test/functional/webpagereplay.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
szym
All current use-cases of ReplayServer set replay_host = '127.0.0.1' so this is essentially a no-op. ...
7 years, 4 months ago (2013-08-23 14:52:31 UTC) #1
dennis_jeffrey
LGTM
7 years, 3 months ago (2013-08-26 16:50:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/23403002/1
7 years, 3 months ago (2013-08-26 17:15:57 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-27 01:28:29 UTC) #4
Message was sent while issue was closed.
Change committed as 219662

Powered by Google App Engine
This is Rietveld 408576698