Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7384)

Unified Diff: chrome/test/functional/webpagereplay.py

Issue 23403002: Pass _replay_host to web-page-replay via --host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/webpagereplay.py
diff --git a/chrome/test/functional/webpagereplay.py b/chrome/test/functional/webpagereplay.py
index 6d2dc5ca74588b0d4f6d754145be43c1bc08c3f6..1c3453acaf1565e4b6a7a2ed4096b904efa6455f 100755
--- a/chrome/test/functional/webpagereplay.py
+++ b/chrome/test/functional/webpagereplay.py
@@ -116,6 +116,7 @@ class ReplayServer(object):
def _AddDefaultReplayOptions(self):
"""Set WPR command-line options. Can be overridden if needed."""
self.replay_options += [
+ '--host', str(self._replay_host),
'--port', str(self._http_port),
'--ssl_port', str(self._https_port),
'--use_closest_match',
@@ -140,9 +141,9 @@ class ReplayServer(object):
# The process has exited.
break
try:
- up_url = '%s://localhost:%s/web-page-replay-generate-200'
- http_up_url = up_url % ('http', self._http_port)
- https_up_url = up_url % ('https', self._https_port)
+ up_url = '%s://%s:%s/web-page-replay-generate-200'
+ http_up_url = up_url % ('http', self._replay_host, self._http_port)
+ https_up_url = up_url % ('https', self._replay_host, self._https_port)
if (200 == urllib.urlopen(http_up_url, None, {}).getcode() and
200 == urllib.urlopen(https_up_url, None, {}).getcode()):
return True
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698