Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentFullscreen.idl

Issue 2340263003: Move Document.fullscreenElement to DocumentOrShadowRoot (Closed)
Patch Set: nits. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentFullscreen.idl
diff --git a/third_party/WebKit/Source/core/dom/DocumentFullscreen.idl b/third_party/WebKit/Source/core/dom/DocumentFullscreen.idl
index 58fb1ef9aa64528912328188867917ea754b9ab7..cee2bb265c93146afccd4055e8c2e2ef03d44b92 100644
--- a/third_party/WebKit/Source/core/dom/DocumentFullscreen.idl
+++ b/third_party/WebKit/Source/core/dom/DocumentFullscreen.idl
@@ -23,21 +23,18 @@
partial interface Document {
[RuntimeEnabled=FullscreenUnprefixed] readonly attribute boolean fullscreenEnabled;
- [RuntimeEnabled=FullscreenUnprefixed] readonly attribute Element? fullscreenElement;
-
[RuntimeEnabled=FullscreenUnprefixed] void exitFullscreen();
[RuntimeEnabled=FullscreenUnprefixed] attribute EventHandler onfullscreenchange;
[RuntimeEnabled=FullscreenUnprefixed] attribute EventHandler onfullscreenerror;
// Mozilla version
- [MeasureAs=PrefixedDocumentIsFullscreen, ImplementedAs=currentFullScreenElement] readonly attribute boolean webkitIsFullScreen;
- [MeasureAs=PrefixedDocumentCurrentFullScreenElement, ImplementedAs=currentFullScreenElement] readonly attribute Element webkitCurrentFullScreenElement;
+ [MeasureAs=PrefixedDocumentIsFullscreen] readonly attribute boolean webkitIsFullScreen;
foolip 2016/09/20 13:44:21 If you change DocumentOrShadowRoot.cpp to simply f
kochi 2016/10/07 14:26:42 Done. Now I see clearly that the original intentio
+
[MeasureAs=PrefixedDocumentCancelFullScreen, ImplementedAs=exitFullscreen] void webkitCancelFullScreen();
// W3C version
[MeasureAs=PrefixedDocumentFullscreenEnabled, ImplementedAs=fullscreenEnabled] readonly attribute boolean webkitFullscreenEnabled;
- [MeasureAs=PrefixedDocumentFullscreenElement, ImplementedAs=fullscreenElement] readonly attribute Element webkitFullscreenElement;
[MeasureAs=PrefixedDocumentExitFullscreen, ImplementedAs=exitFullscreen] void webkitExitFullscreen();
attribute EventHandler onwebkitfullscreenchange;

Powered by Google App Engine
This is Rietveld 408576698