third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp - Issue 2340213002: submit() in submit event handler should not contains a value of a submit button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp

Issue 2340213002: submit() in submit event handler should not contains a value of a submit button. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp b/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp

index 59c7aaf6d11a1c3f82d5d5fa3d4ce6baaf47d99e..e3b2b0db991f21a9e328959e6ebb58b68b63ddfa 100644

--- a/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp

@@ -66,9 +66,7 @@ void SubmitInputType::handleDOMActivateEvent(Event* event)

{

if (element().isDisabledFormControl() || !element().form())

return;

- element().setActivatedSubmit(true);

- element().form()->prepareForSubmission(event); // Event handlers can run.

- element().setActivatedSubmit(false);

+ element().form()->prepareForSubmission(event, &element()); // Event handlers can run.

event->setDefaultHandled();

}