Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: third_party/WebKit/Source/core/html/forms/ImageInputType.cpp

Issue 2340213002: submit() in submit event handler should not contains a value of a submit button. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/ImageInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/ImageInputType.cpp b/third_party/WebKit/Source/core/html/forms/ImageInputType.cpp
index beae5acfdd9adbeddbe629a0ea67c433384f4bdd..8774a1325ff3709181f8d7e6a155461b68fb275e 100644
--- a/third_party/WebKit/Source/core/html/forms/ImageInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/ImageInputType.cpp
@@ -110,10 +110,8 @@ void ImageInputType::handleDOMActivateEvent(Event* event)
{
if (element().isDisabledFormControl() || !element().form())
return;
- element().setActivatedSubmit(true);
m_clickLocation = extractClickLocation(event);
- element().form()->prepareForSubmission(event); // Event handlers can run.
- element().setActivatedSubmit(false);
+ element().form()->prepareForSubmission(event, &element()); // Event handlers can run.
event->setDefaultHandled();
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698