Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 2340083002: Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/compositor/gpu_process_transport_factory.h" 5 #include "content/browser/compositor/gpu_process_transport_factory.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 surface_manager_ = base::WrapUnique(new cc::SurfaceManager); 180 surface_manager_ = base::WrapUnique(new cc::SurfaceManager);
181 181
182 task_graph_runner_->Start("CompositorTileWorker1", 182 task_graph_runner_->Start("CompositorTileWorker1",
183 base::SimpleThread::Options()); 183 base::SimpleThread::Options());
184 #if defined(OS_WIN) 184 #if defined(OS_WIN)
185 software_backing_.reset(new OutputDeviceBacking); 185 software_backing_.reset(new OutputDeviceBacking);
186 #endif 186 #endif
187 } 187 }
188 188
189 GpuProcessTransportFactory::~GpuProcessTransportFactory() { 189 GpuProcessTransportFactory::~GpuProcessTransportFactory() {
190 // If this fails, then we are leaking compositors. 190 DCHECK(per_compositor_data_.empty());
191 CHECK(per_compositor_data_.empty());
192 191
193 // Make sure the lost context callback doesn't try to run during destruction. 192 // Make sure the lost context callback doesn't try to run during destruction.
194 callback_factory_.InvalidateWeakPtrs(); 193 callback_factory_.InvalidateWeakPtrs();
195 194
196 task_graph_runner_->Shutdown(); 195 task_graph_runner_->Shutdown();
197 } 196 }
198 197
199 std::unique_ptr<cc::SoftwareOutputDevice> 198 std::unique_ptr<cc::SoftwareOutputDevice>
200 GpuProcessTransportFactory::CreateSoftwareOutputDevice( 199 GpuProcessTransportFactory::CreateSoftwareOutputDevice(
201 ui::Compositor* compositor) { 200 ui::Compositor* compositor) {
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 shared_vulkan_context_provider_ = 873 shared_vulkan_context_provider_ =
875 cc::VulkanInProcessContextProvider::Create(); 874 cc::VulkanInProcessContextProvider::Create();
876 } 875 }
877 876
878 shared_vulkan_context_provider_initialized_ = true; 877 shared_vulkan_context_provider_initialized_ = true;
879 } 878 }
880 return shared_vulkan_context_provider_; 879 return shared_vulkan_context_provider_;
881 } 880 }
882 881
883 } // namespace content 882 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698