repo: update to v1.12.17-cr1

repo: update to v1.12.17-cr1

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7475196d4c32d66e1c199bf24945b7ae28255e13

[vapier, 2016-09-14 18:26:41]

vapier@chromium.org changed reviewers:
+ akeshet@chromium.org, dgarrett@chromium.org, dnj@chromium.org

[akeshet1, 2016-09-14 19:52:16]

akeshet@google.com changed reviewers:
+ akeshet@google.com

[akeshet1, 2016-09-14 19:52:16]

lgtm

[vapier, 2016-09-14 19:58:45]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:58:54]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[dnj, 2016-09-14 23:02:48]

lgtm w/ comment

https://codereview.chromium.org/2340073002/diff/1/repo
File repo (right):

https://codereview.chromium.org/2340073002/diff/1/repo#newcode868
repo:868: shutil.rmtree(os.path.join(repodir, S_repo), ignore_errors=True)
The previous one actually removed "repodir" too.

[dnj, 2016-09-14 23:03:35]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2016-09-14 23:03:36]

+hinoka@, a depot_tools owner.

[vapier, 2016-09-14 23:04:09]

vapier@chromium.org changed reviewers:
- hinoka@chromium.org

[vapier, 2016-09-14 23:04:09]

https://codereview.chromium.org/2340073002/diff/1/repo
File repo (right):

https://codereview.chromium.org/2340073002/diff/1/repo#newcode868
repo:868: shutil.rmtree(os.path.join(repodir, S_repo), ignore_errors=True)
On 2016/09/14 at 23:02:48, dnj wrote:
> The previous one actually removed "repodir" too.

just to be clear, i didn't "make" these changes ... i copied the "repo" wrapper
unmodified from the repo/ source tree.  so this diff reflects changes that have
landed upstream.

[hinoka, 2016-09-14 23:04:39]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2016-09-14 23:04:40]

lgtm

[vapier, 2016-09-14 23:05:09]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2016-09-14 23:05:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 23:08:37]

Description was changed from

==========
repo: update to v1.12.17-cr1

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted
==========

to

==========
repo: update to v1.12.17-cr1

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7475196d4c32d6...
==========

[commit-bot: I haz the power, 2016-09-14 23:08:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7475196d4c32d6...

[vapier, 2016-10-08 02:28:56]

hmm, looks like my local .git/ was tracking this CL when i tried posting the new
1.12.34.  moved that update to https://codereview.chromium.org/2402193002.