repo: update to v1.12.34-cr2

repo: update to v1.12.34-cr2

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae39f566cadf44fcfac4a885b1039ac5ffe12314

[vapier, 2016-10-08 02:28:16]

vapier@chromium.org changed reviewers:
+ akeshet@chromium.org, akeshet@google.com, dgarrett@chromium.org,
dnj@chromium.org, hinoka@chromium.org

[vapier, 2016-10-08 02:28:16]

assuming bots don't blow up, we can update the launcher.  or maybe we can use a
new launcher with old repo ?  not entirely sure.

[dgarrett, 2016-10-08 02:33:21]

lgtm

[vapier, 2016-10-10 21:36:16]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:36:27]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[vapier, 2016-10-10 21:37:18]

any c-i-t guys want to throw me a bone ? :)

[dnj, 2016-10-10 21:38:16]

dnj@chromium.org changed reviewers:
+ agable@chromium.org, iannucci@chromium.org, nodir@chromium.org

[dnj, 2016-10-10 21:38:16]

Adding some "depot_tools" OWNERS: +agable@, hinoka@, iannucci@, nodir@

[iannucci, 2016-10-10 21:43:49]

rs-lgtm

https://chromiumcodereview.appspot.com/2402193002/diff/1/repo
File repo (right):

https://chromiumcodereview.appspot.com/2402193002/diff/1/repo#newcode8
repo:8: REPO_URL = 'https://chromium.googlesource.com/external/repo'
Does:

  REPO_URL=os.environ.get('REPO_URL', <default value>)

Not work? The current code allows REPO_URL to be set-and-empty, which should
probably be an error condition?

[vapier, 2016-10-10 21:48:22]

https://chromiumcodereview.appspot.com/2402193002/diff/1/repo
File repo (right):

https://chromiumcodereview.appspot.com/2402193002/diff/1/repo#newcode8
repo:8: REPO_URL = 'https://chromium.googlesource.com/external/repo'
it probably does, but keep in mind that this code is being copied from upstream
repo (i didn't write this), and this is the form they've decided to use

i could send a CL to https://gerrit.googlesource.com/git-repo if you really
wanted

[iannucci, 2016-10-10 23:15:44]

On 2016/10/10 21:48:22, vapier wrote:
> https://chromiumcodereview.appspot.com/2402193002/diff/1/repo
> File repo (right):
> 
> https://chromiumcodereview.appspot.com/2402193002/diff/1/repo#newcode8
> repo:8: REPO_URL = 'https://chromium.googlesource.com/external/repo'
> it probably does, but keep in mind that this code is being copied from
upstream
> repo (i didn't write this), and this is the form they've decided to use
> 
> i could send a CL to https://gerrit.googlesource.com/git-repo if you really
> wanted

ah, nvm then. I thought this was a real change and not just copy pasta. lgtm as
is

[vapier, 2016-10-11 02:05:18]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:05:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 02:08:19]

Description was changed from

==========
repo: update to v1.12.34-cr2

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
==========

to

==========
repo: update to v1.12.34-cr2

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae39f566cadf44...
==========

[commit-bot: I haz the power, 2016-10-11 02:08:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae39f566cadf44...