Mechanical refactoring of BrowserProcessImpl::component_updater().

Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the function.

BUG=646904
Committed: https://crrev.com/7a43e83784853f6d73842e9ec60feab67daed8b8
Cr-Commit-Position: refs/heads/master@{#418982}

[Sorin Jianu, 2016-09-14 17:14:30]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-09-14 17:16:03]

Description was changed from

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the executin path
inside the function.

BUG=646904
==========

to

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the executin path
inside the function.

BUG=646904
==========

[Sorin Jianu, 2016-09-14 17:16:03]

sorin@chromium.org changed reviewers:
+ sky@chromium.org

[Sorin Jianu, 2016-09-14 17:16:16]

Description was changed from

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the executin path
inside the function.

BUG=646904
==========

to

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the
function.

BUG=646904
==========

[sky, 2016-09-14 18:11:00]

https://codereview.chromium.org/2340003002/diff/1/chrome/browser/browser_proc...
File chrome/browser/browser_process_impl.cc (right):

https://codereview.chromium.org/2340003002/diff/1/chrome/browser/browser_proc...
chrome/browser/browser_process_impl.cc:895: if
(!BrowserThread::CurrentlyOn(BrowserThread::UI))
I'm a bit confused by this check being only in the path that creates
ComponentUpdater. Why is that?

[commit-bot: I haz the power, 2016-09-14 18:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:19:35]

Dry run: This issue passed the CQ dry run.

[Sorin Jianu, 2016-09-14 18:29:59]

On 2016/09/14 18:11:00, sky wrote:
>
https://codereview.chromium.org/2340003002/diff/1/chrome/browser/browser_proc...
> File chrome/browser/browser_process_impl.cc (right):
> 
>
https://codereview.chromium.org/2340003002/diff/1/chrome/browser/browser_proc...
> chrome/browser/browser_process_impl.cc:895: if
> (!BrowserThread::CurrentlyOn(BrowserThread::UI))
> I'm a bit confused by this check being only in the path that creates
> ComponentUpdater. Why is that?

I agree. A developer's mind stumbles on the said statement. 
First, this is a mechanical refactoring, hence this change must not introduce a
difference in behavior.

This is old code, from when cpu@ roamed in Chromium
(https://codereview.chromium.org/56743002) 

That being said, this is how I have read the code in question.
The code does an idiomatic lazy init of the component_updater_ and returns its
instance when one is available, on
any thread that is calling the accessor.

On the creation path, it forces that an instance of the component_updater is
only created on the UI thread,
which is most likely the case, based on the first call site of this function in
the browser process. This
makes sense, since the component updater code has thread afinity: it needs to be
instantiated and
called on the UI thread or the main thread of the program.

It appears that this was not the case at some point in the past, see the blame
CL referenced above.

I could try to DCHECK this assumption in a future CL.

[sky, 2016-09-14 21:17:41]

LGTM

[Sorin Jianu, 2016-09-15 19:59:45]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:29:50]

Description was changed from

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the
function.

BUG=646904
==========

to

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the
function.

BUG=646904
==========

[commit-bot: I haz the power, 2016-09-15 21:29:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 21:31:40]

Description was changed from

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the
function.

BUG=646904
==========

to

==========
Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the
function.

BUG=646904

Committed: https://crrev.com/7a43e83784853f6d73842e9ec60feab67daed8b8
Cr-Commit-Position: refs/heads/master@{#418982}
==========

[commit-bot: I haz the power, 2016-09-15 21:31:40]

Patchset 1 (id:??) landed as
https://crrev.com/7a43e83784853f6d73842e9ec60feab67daed8b8
Cr-Commit-Position: refs/heads/master@{#418982}