Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 56743002: Add thread safety to Component updater singleton (Closed)

Created:
7 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 1 month ago
Reviewers:
Nico, jam
CC:
chromium-reviews
Visibility:
Public.

Description

In some tests the component updater singleton might be called first from the IO thread which is not expected. This is observed today. BUG=none TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232551

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cpu_(ooo_6.6-7.5)
Committed patchset #2 manually as r232551.
7 years, 1 month ago (2013-11-02 01:57:38 UTC) #1
Nico
I'm not sure if this is the right fix, but maybe I just lack background. ...
7 years, 1 month ago (2013-11-02 05:01:37 UTC) #2
cpu_(ooo_6.6-7.5)
7 years, 1 month ago (2013-11-02 05:16:40 UTC) #3
Message was sent while issue was closed.
I can sort of explain, the component updater singleton needs to be created in
the UI thread. The changes of bug 307193 exposed the singleton to the IO thread.
Which is safe for one method of it but not for component updater creation.

Then some tests call the IO thread component updater singleton ahead of the UI
thread.

Powered by Google App Engine
This is Rietveld 408576698