|
|
DescriptionRemove obsolete Mac flipped coordinates comment.
BUG=637460
TBR=drott
Committed: https://crrev.com/fb7bfc94a65058ccf120e1db58ceae7d7c6bf526
Cr-Commit-Position: refs/heads/master@{#418969}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
wkorman@chromium.org changed reviewers: + ccameron@chromium.org, erikchen@chromium.org
Using this trivial change as a proxy to educate myself on whether there are in fact lingering Mac-specific coordinate system issues. I believe this comment is obsolete. Rationale: - originates from this 2008 change by hyatt@: https://chromium.googlesource.com/chromium/src/+/d5b3878e73bb9c46d4823690c5d2... which was specifically about the incorrect use of point coordinate conversion for rect location which wouldn't do the right thing in a flipped coordinate system. - since then we introduced the use of ThemeMac.mm and LayoutThemeMac.mm both of which set isFlipped to YES, for more see: https://developer.apple.com/reference/appkit/nsview/1483532-isflipped - I've done some work in Mac theme specific logic and much Blink Layout/Paint logic and haven't seen any other references to treating Mac specially in such a manner. - I'm inferring from the above notes that our Mac geometry is now performed in the same 'flipped' coordinate space that we use for other platforms. Please let me know if I'm off base or there's other interesting background or involved code.
Since this is in Blink, I'd suspect that this only has to do with the legacy CoreGraphics drawing path, which has now been torched. Within Blink, Mac should look like everything else.
Description was changed from ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 ========== to ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 TBR=drott ==========
On 2016/09/15 19:06:22, ccameron wrote: > Since this is in Blink, I'd suspect that this only has to do with the legacy > CoreGraphics drawing path, which has now been torched. > > Within Blink, Mac should look like everything else. OK, thanks. It's just a comment removal so with your and erikchen@ feedback (I asked him on chat, he had no insight) I'm removing this and TBR'ing to drott@ as an OWNER.
The CQ bit was checked by wkorman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by wkorman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 TBR=drott ========== to ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 TBR=drott ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 TBR=drott ========== to ========== Remove obsolete Mac flipped coordinates comment. BUG=637460 TBR=drott Committed: https://crrev.com/fb7bfc94a65058ccf120e1db58ceae7d7c6bf526 Cr-Commit-Position: refs/heads/master@{#418969} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fb7bfc94a65058ccf120e1db58ceae7d7c6bf526 Cr-Commit-Position: refs/heads/master@{#418969} |