Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/platform/Widget.h

Issue 2339863003: Remove obsolete Mac flipped coordinates comment. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2008 Collabora Ltd. All rights reserved. 3 * Copyright (C) 2008 Collabora Ltd. All rights reserved.
4 * Copyright (C) 2013 Google Inc. All rights reserved. 4 * Copyright (C) 2013 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 virtual bool isPluginView() const { return false; } 85 virtual bool isPluginView() const { return false; }
86 virtual bool isPluginContainer() const { return false; } 86 virtual bool isPluginContainer() const { return false; }
87 virtual bool isScrollbar() const { return false; } 87 virtual bool isScrollbar() const { return false; }
88 88
89 virtual void setParent(Widget*); 89 virtual void setParent(Widget*);
90 Widget* parent() const { return m_parent; } 90 Widget* parent() const { return m_parent; }
91 Widget* root() const; 91 Widget* root() const;
92 92
93 virtual void handleEvent(Event*) { } 93 virtual void handleEvent(Event*) { }
94 94
95 // It is important for cross-platform code to realize that Mac has flipped c oordinates. Therefore any code
96 // that tries to convert the location of a rect using the point-based conver tFromRootFrame will end
97 // up with an inaccurate rect. Always make sure to use the rect-based conver tFromRootFrame method
98 // when converting window rects.
99 IntRect convertToRootFrame(const IntRect&) const; 95 IntRect convertToRootFrame(const IntRect&) const;
100 IntRect convertFromRootFrame(const IntRect&) const; 96 IntRect convertFromRootFrame(const IntRect&) const;
101 97
102 IntPoint convertToRootFrame(const IntPoint&) const; 98 IntPoint convertToRootFrame(const IntPoint&) const;
103 IntPoint convertFromRootFrame(const IntPoint&) const; 99 IntPoint convertFromRootFrame(const IntPoint&) const;
104 FloatPoint convertFromRootFrame(const FloatPoint&) const; 100 FloatPoint convertFromRootFrame(const FloatPoint&) const;
105 101
106 virtual void frameRectsChanged() { } 102 virtual void frameRectsChanged() { }
107 103
108 virtual void widgetGeometryMayHaveChanged() { } 104 virtual void widgetGeometryMayHaveChanged() { }
(...skipping 16 matching lines...) Expand all
125 private: 121 private:
126 Member<Widget> m_parent; 122 Member<Widget> m_parent;
127 IntRect m_frame; 123 IntRect m_frame;
128 bool m_selfVisible; 124 bool m_selfVisible;
129 bool m_parentVisible; 125 bool m_parentVisible;
130 }; 126 };
131 127
132 } // namespace blink 128 } // namespace blink
133 129
134 #endif // Widget_h 130 #endif // Widget_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698