Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_page.js

Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash. (Closed)
Patch Set: Fix more. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_page.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.js b/chrome/browser/resources/settings/reset_page/reset_page.js
index 6e6e3900b2043defc70b98f0f18f5bb7ee1da2d6..304b6fef7ea1835e9b1d4bacc97ca13e5ccc2a95 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.js
+++ b/chrome/browser/resources/settings/reset_page/reset_page.js
@@ -19,6 +19,8 @@ Polymer({
is: 'settings-reset-page',
properties: {
+ showResetProfileDialog_: Boolean,
+
allowPowerwash_: {
type: Boolean,
value: cr.isChromeOS ? loadTimeData.getBoolean('allowPowerwash') : false
@@ -27,7 +29,10 @@ Polymer({
/** @private */
onShowResetProfileDialog_: function() {
- this.showDialog_('settings-reset-profile-dialog');
+ this.showResetProfileDialog_ = true;
+ this.async(function() {
+ this.$$('settings-reset-profile-dialog').open();
Dan Beam 2016/09/15 21:15:40 wait, why is this better than the original code?
+ }.bind(this));
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698