Issue 233973003: Improve breakpoint resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233973003: Improve breakpoint resolution (Closed)

Created:
6 years, 8 months ago by hausner

Modified:
6 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve breakpoint resolution Fix breakpoint setting in exception handlers. Fixes issue 17880. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34986

Patch Set 3 : #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -27 lines)			Patch
	M	runtime/vm/debugger.h	View		3 chunks	+10 lines, -5 lines	0 comments	Download
	M	runtime/vm/debugger.cc	View	1 2	11 chunks	+40 lines, -22 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/233973003/diff/40001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/233973003/diff/40001/runtime/vm/debugger.cc#newcode1322 runtime/vm/debugger.cc:1322: } ASSERT(requested_token_pos <= last_token_pos);

6 years, 8 months ago (2014-04-11 17:12:07 UTC) #2

hausner

Thank you. https://codereview.chromium.org/233973003/diff/40001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/233973003/diff/40001/runtime/vm/debugger.cc#newcode1322 runtime/vm/debugger.cc:1322: } On 2014/04/11 17:12:07, srdjan wrote: > ...

6 years, 8 months ago (2014-04-11 17:49:05 UTC) #3

hausner

6 years, 8 months ago (2014-04-11 18:04:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r34986 (presubmit successful).

Expand Messages | Collapse Messages

Issue 233973003: Improve breakpoint resolution (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages