Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: runtime/vm/debugger.h

Issue 233973003: Improve breakpoint resolution (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
===================================================================
--- runtime/vm/debugger.h (revision 34933)
+++ runtime/vm/debugger.h (working copy)
@@ -27,10 +27,14 @@
// SourceBreakpoint.
class SourceBreakpoint {
public:
- SourceBreakpoint(intptr_t id, const Script& script, intptr_t token_pos);
+ SourceBreakpoint(intptr_t id,
+ const Script& script,
+ intptr_t token_pos,
+ intptr_t end_token_pos);
RawFunction* function() const { return function_; }
intptr_t token_pos() const { return token_pos_; }
+ intptr_t end_token_pos() const { return end_token_pos_; }
intptr_t id() const { return id_; }
RawScript* script() { return script_; }
@@ -56,6 +60,7 @@
const intptr_t id_;
RawScript* script_;
intptr_t token_pos_;
+ intptr_t end_token_pos_;
bool is_resolved_;
bool is_enabled_;
SourceBreakpoint* next_;
@@ -392,12 +397,12 @@
RawFunction* FindInnermostClosure(const Function& function,
intptr_t token_pos);
intptr_t ResolveBreakpointPos(const Function& func,
- intptr_t requested_token_pos);
+ intptr_t requested_token_pos,
+ intptr_t last_token_pos);
void DeoptimizeWorld();
void SetInternalBreakpoints(const Function& target_function);
- SourceBreakpoint* SetBreakpoint(const Script& script, intptr_t token_pos);
- SourceBreakpoint* SetBreakpoint(const Function& target_function,
- intptr_t first_token_pos,
+ SourceBreakpoint* SetBreakpoint(const Script& script,
+ intptr_t token_pos,
intptr_t last_token_pos);
void RemoveInternalBreakpoints();
void UnlinkCodeBreakpoints(SourceBreakpoint* src_bpt);
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698