Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2339723002: Add Signin_Impression_FromSettings user action for Desktops (Closed)
Patch Set: format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index 42622f135709d3beeff493f5414155ac4a7990df..16daf436a3ac8045e6325aa095019d4ec0706a62 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -184,6 +184,9 @@ Polymer({
* @private
*/
handleSyncStatus_: function(syncStatus) {
+ if (this.syncStatus == null && !syncStatus.signedIn) {
Dan Beam 2016/09/16 18:03:03 if (!this.syncStatus && syncStatus && !syncStatus.
gogerald1 2016/09/16 20:18:07 Done.
Dan Beam 2016/09/16 21:46:36 for future reference, I meant not to use curly bra
+ chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');
+ }
this.syncStatus = syncStatus;
},
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698