Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6725)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 2339723002: Add Signin_Impression_FromSettings user action for Desktops (Closed)
Patch Set: format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | chrome/browser/resources/settings/people_page/people_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 66a170d44a0ad77c04cf364d5a96dc87d78f9c2f..e5f6eaae002a1641e99eaef13f30e41987e17ce6 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -214,6 +214,10 @@ cr.define('options', function() {
// Sync (Sign in) section.
this.updateSyncState_(/** @type {options.SyncStatus} */(
loadTimeData.getValue('syncData')));
+ if (!$('sync-overview').hidden) {
+ chrome.send('metricsHandler:recordAction',
+ ['Signin_Impression_FromSettings']);
+ }
$('start-stop-sync').onclick = function(event) {
if (self.signedIn_) {
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | chrome/browser/resources/settings/people_page/people_page.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698